Move OPENBLAS settings from Base to LinearAlgebra #42473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
previously requested changes
Oct 5, 2021
There was a problem hiding this comment.
I wonder if this is too late and if libopenblas already gets dlopened by the time we reach here.
I think you're right; we should put it here instead. Putting it into the JLL itself more directly ties this to the library, and makes sure that no matter when we do using OpenBLAS_jll, we are guaranteed to set up the environment just in time.
|
It's hard to tell if any of the failing tests are related to this PR. |
|
Buildkite is now passing on master. If you rebase this PR on the latest master, it will use the latest Buildkite configuration. |
ViralBShah
force-pushed
the
vs/openblas-init-2
branch
from
02a1fdb to
56fae48
Compare
DilumAluthge
added
the
external dependencies
|
@staticfloat Can you look at this and merge? Do I have it in the right place in |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* Move OPENBLAS settings from Base to LinearAlgebra * Use __init__ of openblas for setting openblas env variables
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* Move OPENBLAS settings from Base to LinearAlgebra * Use __init__ of openblas for setting openblas env variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if this is too late and if
libopenblasalready getsdlopened by the time we reach here. And if this is ok, can we move this all the way into the__init__for the BLAS module?