-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer: handle timeout correctly #42854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure why we ever used round+1 instead of ceil+1, as this is strictly more correct.
vtjnash
added
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Oct 29, 2021
66 tasks
95 tasks
Could That way interval creep could be addressed by something like
|
What does reset do? |
Reset the timing as if the timer had just been recreated. |
It could error if the timer is closed |
KristofferC
pushed a commit
that referenced
this pull request
Nov 10, 2021
I am not sure why we ever used round+1 instead of ceil+1, as this is simply strictly more correct. (cherry picked from commit d6f59fa)
daviehh
pushed a commit
to daviehh/julia
that referenced
this pull request
Nov 16, 2021
I am not sure why we ever used round+1 instead of ceil+1, as this is simply strictly more correct. (cherry picked from commit d6f59fa)
29 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 7, 2021
I am not sure why we ever used round+1 instead of ceil+1, as this is simply strictly more correct. (cherry picked from commit d6f59fa)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
I am not sure why we ever used round+1 instead of ceil+1, as this is simply strictly more correct.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
I am not sure why we ever used round+1 instead of ceil+1, as this is simply strictly more correct.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
I am not sure why we ever used round+1 instead of ceil+1, as this is simply strictly more correct. (cherry picked from commit d6f59fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why we ever used round+1 instead of ceil+1, as this is
strictly more correct.