Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Bump the Downloads stdlib from c91876a to 4250b35 #42935

Merged

Conversation

DilumAluthgeBot
Copy link
Contributor

@DilumAluthgeBot DilumAluthgeBot commented Nov 4, 2021

Stdlib: Downloads
URL: https://github.com/JuliaLang/Downloads.jl.git
Branch: master
Old commit: c91876a
New commit: 4250b35
Bump invoked by: @DilumAluthge
Powered by: BumpStdlibs.jl

$ git log --oneline c91876a..4250b35
4250b35 Check for timer isopen correctly (#162)
7f91b8a Workaround for missing isopen check in FDWatcher (#161)
62b497e fix Timer usage (#158)
f856630 Merge pull request #157 from JuliaLang/revert-156-revert-151-sk/no-libuv-sushi
43a3484 add missing locks during Timer callbacks
69acc13 Revert "Revert "stop using raw libuv API" (#156)"

@DilumAluthge
Copy link
Member

If possible, it would be nice to hold off on merging this until #42885 is merged.

@StefanKarpinski
Copy link
Member

Well, I guess the good news is that the CI failures don't appear to be related to Downloads? Can hold off for whatever or re-bump afterwards. Whatever's convenient.

@DilumAluthgeBot DilumAluthgeBot force-pushed the BumpStdlibs/Downloads-4250b35 branch from e2aa137 to de3df0d Compare November 4, 2021 19:34
@DilumAluthge
Copy link
Member

I merged #42885 and triggered a new bump. Now the Pkg test suite is going to run on this bump PR, so we can see whether or not it breaks the Pkg tests.

@StefanKarpinski
Copy link
Member

FreeBSD failure is some LBT issue. Presumably unrelated.

@DilumAluthge
Copy link
Member

Yeah, I think the tester_freebsd64 failure is unrelated. I'll open an issue.

It looks like the Pkg test suite passed (on Buildkite), which is good news.

If all CI jobs (other than tester_freebsd64) pass, I think that this is good to merge.

@DilumAluthge
Copy link
Member

Yeah, I think the tester_freebsd64 failure is unrelated. I'll open an issue.

#42944

@DilumAluthge
Copy link
Member

The tester_win64 failures are not due to this PR. See #42950

@DilumAluthge DilumAluthge merged commit fa62616 into JuliaLang:master Nov 5, 2021
@StefanKarpinski
Copy link
Member

Fingers crossed that this one sticks and we finally have a threadsafe Downloads.

@DilumAluthgeBot DilumAluthgeBot deleted the BumpStdlibs/Downloads-4250b35 branch November 7, 2021 01:52
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants