Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use name in source module when importing an aliased binding #43291

Merged
merged 2 commits into from
Feb 28, 2022
Merged

use name in source module when importing an aliased binding #43291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eea8cc
use name in source module when importing an aliased binding
Pangoraw Dec 1, 2021
060016d
Merge remote-tracking branch 'origin/master' into binding_name
simeonschaub Feb 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ static void module_import_(jl_module_t *to, jl_module_t *from, jl_sym_t *s, jl_s
}
}
else {
jl_binding_t *nb = new_binding(s);
jl_binding_t *nb = new_binding(b->name);
nb->owner = b->owner;
nb->imported = (explici!=0);
nb->deprecated = b->deprecated;
Expand Down
6 changes: 6 additions & 0 deletions test/syntax.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2514,6 +2514,7 @@ end
end

module Mod2
import ..Mod.x as x_from_mod
const y = 2
end

Expand Down Expand Up @@ -2554,6 +2555,11 @@ import .Mod.@mac as @m
@test_throws ErrorException eval(:(import .Mod.func as @notmacro))
@test_throws ErrorException eval(:(using .Mod: @mac as notmacro))
@test_throws ErrorException eval(:(using .Mod: func as @notmacro))

import .Mod2.x_from_mod

@test @isdefined(x_from_mod)
@test x_from_mod == Mod.x
end

import .TestImportAs.Mod2 as M2
Expand Down