fix #44153, limit input types of reflection utilities #44155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #43113 Julia compiler can inline `@nospecialize ::AbstractType` signature, so we can reintroduce the input type annotations. Still I want to keep the current `::Any` signature for those utility functions heavily in `Core.Compiler` (e.g. `isbitstype`) because `isa(t, Type)` check inserted by the inliner otherwise might involve some cost. But I agree that the other non-performance sensitive functions like `which` is better to have input type restrictions.
simeonschaub
approved these changes
Feb 13, 2022
There was a problem hiding this comment.
Still I want to keep the current
::Anysignature for those utility
functions heavily inCore.Compiler(e.g.isbitstype) becauseisa(t, Type)
check inserted by the inliner otherwise might involve some cost.
Yes, I think those should be fine, they shouldn't lead to segfaults at least.
simeonschaub
added
bugfix
vtjnash
approved these changes
Feb 13, 2022
There was a problem hiding this comment.
LGTM. At some point we should try to handle the Union case too though, since that is also a type it can encounter:
julia> which(Union{Tuple{typeof(+),Int64,Int64}, Tuple{typeof(+),Int32,Int32}})
julia: /data/vtjnash/julia/src/gf.c:2775: ml_matches: Assertion `jl_is_datatype(unw)' failed.
julia> Base._methods_by_ftype(Union{Tuple{typeof(+),Int64,Int64}, Tuple{typeof(+),Int32,Int32}}, -1, Base.get_world_counter())
julia: /data/vtjnash/julia/src/gf.c:2775: ml_matches: Assertion `jl_is_datatype(unw)' failed.
|
aha, so |
DilumAluthge
removed
the
merge me
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
…Lang#44155) After JuliaLang#43113 Julia compiler can inline `@nospecialize ::AbstractType` signature, so we can reintroduce the input type annotations. Still I want to keep the current `::Any` signature for those utility functions heavily in `Core.Compiler` (e.g. `isbitstype`) because `isa(t, Type)` check inserted by the inliner otherwise might involve some cost. But I agree that the other non-performance sensitive functions like `which` is better to have input type restrictions.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…Lang#44155) After JuliaLang#43113 Julia compiler can inline `@nospecialize ::AbstractType` signature, so we can reintroduce the input type annotations. Still I want to keep the current `::Any` signature for those utility functions heavily in `Core.Compiler` (e.g. `isbitstype`) because `isa(t, Type)` check inserted by the inliner otherwise might involve some cost. But I agree that the other non-performance sensitive functions like `which` is better to have input type restrictions.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…Lang#44155) After JuliaLang#43113 Julia compiler can inline `@nospecialize ::AbstractType` signature, so we can reintroduce the input type annotations. Still I want to keep the current `::Any` signature for those utility functions heavily in `Core.Compiler` (e.g. `isbitstype`) because `isa(t, Type)` check inserted by the inliner otherwise might involve some cost. But I agree that the other non-performance sensitive functions like `which` is better to have input type restrictions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #43113 Julia compiler can inline
@nospecialize ::AbstractTypesignature, so we can reintroduce the input type annotations.
Still I want to keep the current
::Anysignature for those utilityfunctions heavily in
Core.Compiler(e.g.isbitstype) becauseisa(t, Type)check inserted by the inliner otherwise might involve some cost.
But I agree that the other non-performance sensitive functions like
whichis better to have input type restrictions.