Transition pipeline to NewPM #44365
Closed
Transition pipeline to NewPM #44365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
commented
Mar 1, 2022
src/aotcompile.cpp
Outdated
| LoopPassManager LPM; | ||
| LPM.addPass(LICMPass()); | ||
| LPM.addPass(JuliaLICMPass()); | ||
| LPM.addPass(SimpleLoopUnswitchPass()); |
There was a problem hiding this comment.
@neboat mentioned that this is not equivalent to LoopUnswitch
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
from
2238add to
09b72e6
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
from
43e9ee3 to
a0a1715
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
2 times, most recently
from
7e3f091 to
2c6397d
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
2 times, most recently
from
800104c to
586b579
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
from
586b579 to
e47d586
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
3 times, most recently
from
8bb1b96 to
e8722f5
Compare
vchuravy
force-pushed
the
vc/llvm_14.0.2
branch
2 times, most recently
from
80d3af5 to
1c5858b
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
from
1b8a0ce to
4119135
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
3 times, most recently
from
b4e44f0 to
52d2b50
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
from
52d2b50 to
35b4042
Compare
pchintalapudi
force-pushed
the
vc/newpm_pipeline
branch
from
35b4042 to
06b2a73
Compare
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now a fairly direct translation from our old pipeline
to the new PM. For one of the Loop sections I have choosen the new Loop specific passes
to avoid invalidation loop analysis to soon.
Still have to figure out how to properly use this in lieu of the old PM, since it seems
we need to keep the analysis managers around for the lifetime of the MPM.