Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM build to 14.0.6+2 #48544

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Update LLVM build to 14.0.6+2 #48544

merged 2 commits into from
Feb 8, 2023

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Feb 5, 2023

Fixes #48020 and fixes #48057

Maybe also #48499

@vchuravy vchuravy added this to the 1.9 milestone Feb 5, 2023
@vchuravy vchuravy added the backport 1.9 Change should be backported to release-1.9 label Feb 5, 2023
@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs labels Feb 5, 2023
@giordano
Copy link
Contributor

giordano commented Feb 5, 2023

Checksums are not right?

@giordano
Copy link
Contributor

giordano commented Feb 5, 2023

It doesn't seem to fix #48020 for me, I still see the broken stacktrace.

@gbaraldi
Copy link
Member

gbaraldi commented Feb 5, 2023

I do get the correct error here. Maybe add a test?
@giordano LLVM is sometimes stubborn so you might have to delete some extra files.
At least on linux it works.

@giordano
Copy link
Contributor

giordano commented Feb 5, 2023

julia> using Cuba
ERROR: InitError: This is an error inside __init__
Stacktrace:
  [1] error
    @ ~/.julia/compiled/v1.10/Cuba/UN24D_YmJXR.dylib:-1
  [2] __init__()
    @ Cuba ~/.julia/compiled/v1.10/Cuba/UN24D_YmJXR.dylib:-1
  [3] register_restored_modules(sv::Core.SimpleVector, pkg::Base.PkgId, path::String)
    @ Base ./loading.jl:1070
  [4] _include_from_serialized(pkg::Base.PkgId, path::String, ocachepath::String, depmods::Vector{Any})
    @ Base ./loading.jl:1014
  [5] _require_search_from_serialized(pkg::Base.PkgId, sourcepath::String, build_id::UInt128)
    @ Base ./loading.jl:1416
  [6] _require(pkg::Base.PkgId, env::String)
    @ Base ./loading.jl:1693
  [7] _require_prelocked(uuidkey::Base.PkgId, env::String)
    @ Base ./loading.jl:1570
  [8] macro expansion
    @ ./loading.jl:1558 [inlined]
  [9] macro expansion
    @ ./lock.jl:267 [inlined]
 [10] require(into::Module, mod::Symbol)
    @ Base ./loading.jl:1521
during initialization of module Cuba

julia> versioninfo()
Julia Version 1.10.0-DEV.436
Commit 3341a02f76* (2023-02-05 20:15 UTC)
Platform Info:
  OS: macOS (arm64-apple-darwin21.6.0)
  CPU: 8 × Apple M1
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, apple-m1)
  Threads: 1 on 4 virtual cores

At least on linux it works.

On Linux it has always worked.

@giordano
Copy link
Contributor

giordano commented Feb 5, 2023

And I still get the same on a completely fresh clone of Julia, to avoid caching issues (but I did run make cleanall before compiling in my usual repo). I have macOS 12.6, in case that makes any difference.

@vchuravy
Copy link
Member Author

vchuravy commented Feb 5, 2023

make -C deps reinstall-llvm?

@giordano
Copy link
Contributor

giordano commented Feb 5, 2023

That didn't change anything. Not that I was expecting anything else since I just cloned this repository into a new directory and did a complete rebuild of julia without any pre-existing cache 🙂

@gbaraldi
Copy link
Member

gbaraldi commented Feb 5, 2023

For reference this fixes it in Macos13 but not on 12.6

@vchuravy
Copy link
Member Author

vchuravy commented Feb 6, 2023

@nanosoldier runtests()

1 similar comment
@vchuravy
Copy link
Member Author

vchuravy commented Feb 7, 2023

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

Your job failed. Consult the server logs for more details (cc @maleadt).

@maleadt
Copy link
Member

maleadt commented Feb 8, 2023

PkgEval is a bit unstable due to an OS upgrade, so let's try again:

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

Your job failed. Consult the server logs for more details (cc @maleadt).

@maleadt
Copy link
Member

maleadt commented Feb 8, 2023

And again:

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@vchuravy vchuravy merged commit 43c6f75 into master Feb 8, 2023
@vchuravy vchuravy deleted the vc/update_llvm branch February 8, 2023 13:12
@oscardssmith
Copy link
Member

@vchuravy when trying to build with local LLVM, this gives me

make USE_BINARYBUILDER_LLVM=0 -j
fatal: couldn't find remote ref julia-14.0.6-2
fatal: couldn't find remote ref remotes/origin/julia-14.0.6-2
make[1]: *** [~/julia/deps/llvm.mk:11:~/julia/deps/srccache/llvm/source-extracted] Error 128
make: *** [Makefile:75: julia-deps] Error 2

Any idea what's going on?

@gbaraldi
Copy link
Member

gbaraldi commented Feb 9, 2023

I think we might be missing a tag on our llvm branch @vchuravy

@stahta01
Copy link
Contributor

stahta01 commented Feb 9, 2023

I think we might be missing a tag on our llvm branch @vchuravy

Correct the tag is missing or the version was supposed to be julia-14.0.6-1

git fetch origin julia-14.0.6-2
fatal: couldn't find remote ref julia-14.0.6-2
git fetch origin julia-14.0.6-1
From https://github.com/JuliaLang/llvm-project
 * tag                         julia-14.0.6-1 -> FETCH_HEAD

@vchuravy
Copy link
Member Author

vchuravy commented Feb 9, 2023

Sorry pushed the tag.

@DilumAluthge
Copy link
Member

@vchuravy Can you update the following source checksum?

ERROR: The working directory is dirty.
--
  | Output of git status:
  | HEAD detached at 6cbcee9cb05
  | Untracked files:
  | (use "git add <file>..." to include in what will be committed)
  |  
  | deps/checksums/llvm-julia-14.0.6-2.tar.gz/
  |  
  | nothing added to commit but untracked files present (use "git add" to track)
  | 🚨 Error: The command exited with status 1

KristofferC pushed a commit that referenced this pull request Feb 20, 2023
@KristofferC KristofferC mentioned this pull request Feb 20, 2023
50 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs
Projects
None yet
9 participants