Skip to content

Fix typo in >= 3 arg fastmath method #54630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 1 commit into from
May 30, 2024
Merged

Fix typo in >= 3 arg fastmath method #54630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/fastmath.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ for op in (:+, :*, :min, :max)
# definitions down to avoid losing type information.
# type promotion
$op_fast(a::Number, b::Number, c::Number, xs::Number...) =
$op_fast(promote(x,y,c,xs...)...)
$op_fast(promote(a,b,c,xs...)...)
# fall-back implementation that applies after promotion
$op_fast(a::T, b::T, c::T, xs::T...) where {T<:Number} = (@inline; afoldl($op_fast, ($op_fast)(($op_fast)(a,b),c), xs...))
end
Expand Down
6 changes: 6 additions & 0 deletions test/fastmath.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,3 +343,9 @@ end
x = @fastmath maximum(Float16[1,2,3]; init = Float16(0))
@test x == Float16(3)
end

@testset "Test promotion of >=3 arg fastmath" begin
# Bug caught in https://github.com/JuliaLang/julia/pull/54513#discussion_r1620553369
x = @fastmath 1. + 1. + 1f0
@test x == 3.0
end