-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Bump to SparseArrays.jl PR with 7.10.1 wrappers for testing #57745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Issue is checksums... Updating. |
34c47ee to
660996f
Compare
660996f to
ee40363
Compare
| @@ -1,4 +1,2 @@ | |||
| mmtk_julia-4933fb41ba5d1d21f720e2ca1bfa5bc938b73b12.tar.gz/md5/e27debba476479953bdc23eb970f297f | |||
| mmtk_julia-4933fb41ba5d1d21f720e2ca1bfa5bc938b73b12.tar.gz/sha512/6541bacfd16cbf1969103fea612c2f8b2011c3e38748bf82c41633c6084c2bf981bca9fb0d9f736832b0d7ef505271ba48465bcd27e8cd1fa45f7f4c5e36f246 | |||
| mmtk_julia.v0.30.6+0.x86_64-linux-gnu.tar.gz/md5/9b0c3e1ae95d82aa2184cbe889def0da | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this an accidental change? I'm not 100% sure but It looks like the Julia+MMTk build is currently broken because of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the refresh checksums script, which is often quite problematic. So it may have unintentionally broken that build.
Maybe I request you to add the missing checksums back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. Will do :)
) Some redundant checksums were added in #57745 (likely by the checksum refresh script), which was giving me build failures on a fresh clone by calculating the "true" checksum of suitesparse to be the concatenation of many checksums. This PR deletes the extras and fixes the handling of this in the future.
|
Was this PR merged by accident? It said it was for testing only and there are some randomly deleted checksum files and other unrelated ones that got modified. Should those checksum files be restored or? Probably best to use BumpStdlibs in the future. |
|
It was for testing initially but later was updated to the final commit. A follow up PR has fixed the checksum generation script. AFAICT the deleted checksum files got incorporated in another file by jlchecksum. and some missing ones were added. |
This is for testing only. Once JuliaSparse/SparseArrays.jl#608 merges, use the BumpStdlibs.jl to bump SparseArrays.jl.