Skip to content

Conversation

@ViralBShah
Copy link
Member

This is for testing only. Once JuliaSparse/SparseArrays.jl#608 merges, use the BumpStdlibs.jl to bump SparseArrays.jl.

@ViralBShah ViralBShah marked this pull request as draft March 12, 2025 20:44
@ViralBShah
Copy link
Member Author

ViralBShah commented Mar 13, 2025

Issue is checksums... Updating.

@ViralBShah ViralBShah force-pushed the vs/ss-7.10.1-sparsearrays branch 3 times, most recently from 34c47ee to 660996f Compare March 13, 2025 16:03
@ViralBShah ViralBShah force-pushed the vs/ss-7.10.1-sparsearrays branch from 660996f to ee40363 Compare March 13, 2025 16:09
@ViralBShah ViralBShah marked this pull request as ready for review March 13, 2025 19:53
@ViralBShah ViralBShah merged commit 2f54acb into master Mar 13, 2025
4 of 7 checks passed
@ViralBShah ViralBShah deleted the vs/ss-7.10.1-sparsearrays branch March 13, 2025 21:12
@@ -1,4 +1,2 @@
mmtk_julia-4933fb41ba5d1d21f720e2ca1bfa5bc938b73b12.tar.gz/md5/e27debba476479953bdc23eb970f297f
mmtk_julia-4933fb41ba5d1d21f720e2ca1bfa5bc938b73b12.tar.gz/sha512/6541bacfd16cbf1969103fea612c2f8b2011c3e38748bf82c41633c6084c2bf981bca9fb0d9f736832b0d7ef505271ba48465bcd27e8cd1fa45f7f4c5e36f246
mmtk_julia.v0.30.6+0.x86_64-linux-gnu.tar.gz/md5/9b0c3e1ae95d82aa2184cbe889def0da
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this an accidental change? I'm not 100% sure but It looks like the Julia+MMTk build is currently broken because of it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the refresh checksums script, which is often quite problematic. So it may have unintentionally broken that build.

Maybe I request you to add the missing checksums back?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Will do :)

ViralBShah pushed a commit that referenced this pull request Mar 21, 2025
)

Some redundant checksums were added in #57745 (likely by the checksum
refresh script), which was giving me build failures on a fresh clone by
calculating the "true" checksum of suitesparse to be the concatenation
of many checksums. This PR deletes the extras and fixes the handling of
this in the future.
@KristofferC
Copy link
Member

Was this PR merged by accident? It said it was for testing only and there are some randomly deleted checksum files and other unrelated ones that got modified. Should those checksum files be restored or? Probably best to use BumpStdlibs in the future.

@ViralBShah
Copy link
Member Author

It was for testing initially but later was updated to the final commit. A follow up PR has fixed the checksum generation script.

AFAICT the deleted checksum files got incorporated in another file by jlchecksum. and some missing ones were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants