Always set result.src to the result of transform_result_for_cache
#58083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlining can look at `result.src` for things that are put in the global cache via the `VolatileInferenceResult` mechanism. As a result, we need to appropriately update the reference here or inlining will see un-transformed (and thus potentially garbage) objects. The dataflow here is quite confusing and should undergo a larger refactor, but this fixes the immediate issue.
vtjnash
added a commit
that referenced
this pull request
Apr 22, 2025
Keno
added a commit
that referenced
this pull request
Apr 30, 2025
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
…uliaLang#58083) Inlining can look at `result.src` for things that are put in the global cache via the `VolatileInferenceResult` mechanism. As a result, we need to appropriately update the reference here or inlining will see un-transformed (and thus potentially garbage) objects. The dataflow here is quite confusing and should undergo a larger refactor, but this fixes the immediate issue.
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
JuliaLang#58182) The point of JuliaLang#57979 was to make inference faster, but it made it instead much slower (JuliaLang@83524ac#commitcomment-155658124), so revert back to the fast behavior before it was "optimized" (and revert the bugfixes for the original commit).
serenity4
added a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
JuliaLang#58203) Reverts JuliaLang#58182. The API changes were intentional and desirable. Let's figure out why nansoldier was upset and re-apply this. --------- Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com>
LebedevRI
pushed a commit
to LebedevRI/julia
that referenced
this pull request
May 2, 2025
JuliaLang#58182) The point of JuliaLang#57979 was to make inference faster, but it made it instead much slower (JuliaLang@83524ac#commitcomment-155658124), so revert back to the fast behavior before it was "optimized" (and revert the bugfixes for the original commit).
charleskawczynski
pushed a commit
to charleskawczynski/julia
that referenced
this pull request
May 12, 2025
JuliaLang#58203) Reverts JuliaLang#58182. The API changes were intentional and desirable. Let's figure out why nansoldier was upset and re-apply this. --------- Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlining can look at
result.srcfor things that are put in the global cache via theVolatileInferenceResultmechanism. As a result, we need to appropriately update the reference here or inlining will see un-transformed (and thus potentially garbage) objects. The dataflow here is quite confusing and should undergo a larger refactor, but this fixes the immediate issue.