RFC: the generalized eigenvalue problem (#6758) #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function eigs(A;nev::Integer=6, ncv::Integer=20, which::ASCIIString="LM", | ||
| eigs(A; args...) = eigs(A, :Identity, args...) | ||
|
|
||
| function eigs(A, B; nev::Integer=6, ncv::Integer=20, which::ASCIIString="LM", |
There was a problem hiding this comment.
Might consider changing which to be a symbol, which seems to be the direction we are going with parameters such as this? Or does it matter?
I guess that change could be separate from this PR.
Remove complexOP keyword argument, as I believe it was not used correctly. Update docs and add tests.
|
The GEP support is almost ready to merge. @kmsquire We could also move the |
ViralBShah
changed the title
ViralBShah
added a commit
that referenced
this pull request
May 18, 2014
RFC: the generalized eigenvalue problem (#6758)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for the generalized eigenvalue problem (#6758)