Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. drop trailing singleton dimensions, as discussed here.
Example:
I think it's correct, but since it's not a trivial change, I'll leave it here for review/further discussion instead of pushing it directly.
Also, there's still a difference in behaviour, since
sub
still only allows either 1 index or the same number of indices as the parent array, but I think it was decided it'sref
which has to change in that case.