more methods working with a non-global RNG #8380
Conversation
| as_unsigned(::Type{Int64} ) = Uint64 | ||
| as_unsigned(::Type{Int128}) = Uint128 | ||
|
|
||
| as_signed{T<:Integer128}(x::T) = convert(as_signed(T), x) |
There was a problem hiding this comment.
Doesn't convert(Signed, x) already do this?
There was a problem hiding this comment.
Then you could just do Signed(x) and Unsigned(x)...
There was a problem hiding this comment.
It's weird, I remember having answered ("no") to Jeff's above comment but can't see it: can an inline comment be deleted when rebasing?
Yes this PR needs to be updated and rebased, unless it is deemed worthless.
|
Nice to have this refactored. Sorry I stepped on your changes; rebasing should be pretty easy though. |
|
Should #8331 be closed in favor of this? This PR seems more comprehensive. |
|
Ok I will rebase tomorrow. Yes #8331 can be closed (there is 1 new commit in this current PR). |
MersenneTwister's constructor making an instance with an Uint32 seed were removed in commit 4fb4622. But a subsequent call to srand(r::MersenneTwister, seed) would only accept an Uint32 as a seed, and would always make r.seed an Uint32; this was not consistent.
The srand methods working on a MersenneTwister instance did not catch up with those working on the global RNG. They are now made similar thanks to the make_seed function, which implements the different logics. Also, the manual is more precise on the types of valid seeds.
And similarly for rand!, randbool. Fixes JuliaLang#8360.
rfourquet
force-pushed
the
random-rng
branch
from
91d78ae to
8f8e43d
Compare
|
Rebased and closed #8331. |
jiahao
force-pushed
the
master
branch
3 times, most recently
from
6c7c7e3 to
1a4c02f
Compare
|
Bump. This should be looked at in light of #8786 |
|
Superseded by #8854. |
This is branched off of my other PR #8331 and continues it: the new commit here makes almost all
randmethods work with a passed RNG. The main exception isrand(r::Range, ...)as I already touched this part of the code in #8309, so I prefer to wait before implementing it.Also the value of
(srand(0); rand(Uint64))changes here, to make the function more natural and similar torand(Uint128). I can revert this if considered a (worthless) breaking change.