remove evaluate function for functor types
#8790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @inbounds fx = evaluate(f, A[ifirst+=1]) | ||
| v = evaluate(op, v, fx) | ||
| fx = f(A[ifirst+=1]) | ||
| v = op(v, fx) |
There was a problem hiding this comment.
There seems te be an @inbounds missing in line 137 in comparison to old line 133.
jakebolewski
force-pushed
the
jcb/rm_evaluate
branch
from
d7c5549 to
0c631f8
Compare
jakebolewski
added a commit
that referenced
this pull request
Oct 24, 2014
remove `evaluate` function for functor types
simonster
added a commit
to JuliaStats/DataArrays.jl
that referenced
this pull request
Oct 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functor types are now callable due to #8712.