Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Explain how to extract svds-factors #52

Merged
merged 1 commit into from
Nov 21, 2018
Merged

[RFC] Explain how to extract svds-factors #52

merged 1 commit into from
Nov 21, 2018

Conversation

dkarrasch
Copy link
Member

@dkarrasch dkarrasch commented Nov 10, 2018

Fixes JuliaLang/julia#18. I have shamelessly taken the original JuliaLang-PR as a basis for further modifications. Some changes:

  • I have removed the claim that U*Diagonal(S)*Vt yield A, and reformulated towards low-rank approximation.
  • I'm not sure the sentence

Internally Vt is stored and hence Vt is more efficient to extract than V.

is true anymore, since Vt is just wrapped by an Adjoint. I kept the sentence for the time being.

  • In the doctest, I removed the (redundant) reference to sparsity to avoid additional package dependency, in case that's an issue.

@coveralls
Copy link

coveralls commented Nov 10, 2018

Pull Request Test Coverage Report for Build 97

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.279%

Totals Coverage Status
Change from base Build 96: 0.0%
Covered Lines: 183
Relevant Lines: 272

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Nov 10, 2018

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      JuliaLang/julia#52   +/-   ##
=======================================
  Coverage   67.27%   67.27%           
=======================================
  Files           2        2           
  Lines         272      272           
=======================================
  Hits          183      183           
  Misses         89       89
Impacted Files Coverage Δ
src/Arpack.jl 50.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6ba90...918f303. Read the comment docs.

@andreasnoack andreasnoack merged commit 04defa4 into JuliaLinearAlgebra:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.*3 parses as (2.)*(3) instead of (2).*(3)
4 participants