Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finite differences: shouldn't we count f_calls? #219

Closed
pkofod opened this issue Jun 9, 2016 · 7 comments
Closed

Finite differences: shouldn't we count f_calls? #219

pkofod opened this issue Jun 9, 2016 · 7 comments

Comments

@pkofod
Copy link
Member

pkofod commented Jun 9, 2016

Shouldn't we count the function evaluations done in finite differences towards f_calls?

@johnmyleswhite
Copy link
Contributor

Yes, but we can't ask that library to do that. We should still be able to do it by assuming it's 2 * n where n = length(x) and x is the vector of parameters being optimized over.

@KristofferC
Copy link
Contributor

It is sort of possible to have the library do it by passing in a closure that modifies the variable when it is called but the performance for this has been quite shaky lately on master.

@johnmyleswhite
Copy link
Contributor

That's technically possible but seems to needlessly complicated the finite differencing code.

@pkofod
Copy link
Member Author

pkofod commented Jun 9, 2016

I was just thinking about the 2*n solution. Is there any way it can be something else?

@johnmyleswhite
Copy link
Contributor

Only if we don't specify that we want central differencing and the default were to change.

@pkofod
Copy link
Member Author

pkofod commented Jun 9, 2016

Okay, I guess we'll just have to be careful then :) I guess we do need some sort of flag though, to pass through to the optimizer, so it knows if it is using finite differences or not (we could show a gradient: user provided, finite differences, or automatic differentiation line in the output as well).

@cortner
Copy link
Contributor

cortner commented Jun 20, 2016

Aren't there techniques to compute multiple finite difference at the same time, if the sparsity structure is known? Maybe better to fix the packages that perform the fds?

@pkofod pkofod changed the title Finite differences... Finite differences: shouldn't we count f_calls? Jul 20, 2016
@pkofod pkofod mentioned this issue Dec 22, 2016
13 tasks
@pkofod pkofod closed this as completed Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants