oneAPI: Restore IGC OpenCL support. #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
force-pushed
the
tb/libigc_opencl
branch
from
56b27d9
to
e939d86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had removed OpenCL support because oneAPI.jl doesn't use it, but now it turns out the NEO_jll build process uses IGC's OpenCL compiler to compile builtins... Hopefully we can split the package at some point using JuliaPackaging/BinaryBuilder.jl#778, but I don't feel like doing it manually right now, so just restore the OpenCL bits (but always strip debug info to reduce the JLL size).