Change isdefined for @isdefined because the new function isdefined needs #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two arguments, the first being the name of the module where the symbol must be define remove the deprecated readstring
|
Oh! |
stevengj
reviewed
Aug 10, 2018
| @@ -4,10 +4,10 @@ module DefaultDeps | |||
| if isfile("deps.jl") | |||
| include("deps.jl") | |||
| end | |||
| if !isdefined(:ROOTENV) | |||
| if !@isdefined(ROOTENV) | |||
There was a problem hiding this comment.
This will break Julia 0.6. Maybe change it to !isdefined(@__MODULE__, :ROOTENV)
stevengj
reviewed
Aug 10, 2018
| @@ -32,7 +32,7 @@ const ROOTENV = "$(escape_string(ROOTENV))" | |||
| const MINICONDA_VERSION = "$(escape_string(MINICONDA_VERSION))" | |||
| """ | |||
|
|
|||
| if !isfile("deps.jl") || readstring("deps.jl") != deps | |||
| if !isfile("deps.jl") || open(f->read(f,String),"deps.jl") != deps | |||
There was a problem hiding this comment.
read("deps.jl", String) should work
|
Duplicate of #113. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if my PR is sufficent, but I managed to install Conda with the new version 1.0.
i need to modify
isdefined for the macro @isdefined because the new version has two arguments
I replace also readstring by open(f->read(f,String)