-
Notifications
You must be signed in to change notification settings - Fork 72
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Affects: JuliaCall
>>> from juliacall import Main
>>> Main.seval("""
... function f()
... 0
... end
... """)
Julia: f (generic function with 1 method)
>>> if True:
... Main.seval("""
... function g()
... 1
... end
... """)
...
Traceback (most recent call last):
File "<stdin>", line 2, in <module>
File "/Users/x/.julia/packages/PythonCall/qTEA1/src/jlwrap/module.jl", line 25, in seval
return self._jl_callmethod($(pyjl_methodnum(pyjlmodule_seval)), expr)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
juliacall.JuliaError: Base.Meta.ParseError("extra token after end of expression")
Stacktrace:
[1] parse(str::String; raise::Bool, depwarn::Bool)
@ Base.Meta ./meta.jl:272
[2] parse
@ ./meta.jl:266 [inlined]
[3] pyjlmodule_seval(self::Module, expr::Py)
@ PythonCall ~/.julia/packages/PythonCall/qTEA1/src/jlwrap/module.jl:13
[4] _pyjl_callmethod(f::Any, self_::Ptr{PythonCall.C.PyObject}, args_::Ptr{PythonCall.C.PyObject}, nargs::Int64)
@ PythonCall ~/.julia/packages/PythonCall/qTEA1/src/jlwrap/base.jl:62
[5] _pyjl_callmethod(o::Ptr{PythonCall.C.PyObject}, args::Ptr{PythonCall.C.PyObject})
@ PythonCall.C ~/.julia/packages/PythonCall/qTEA1/src/cpython/jlwrap.jl:47
The issue is that Python's multiline string parsing is different from Julia's and does not strip trailing spaces as much, so the strict behavior of Julia's Meta.parse
does not make sense for strings that were written using Python's multiline string syntax.
I think PyCall doesn't have this issue, but I'm not positive.
I think that a good solution would be to strip inputs before parsing. It's hard to imagine a case when someone would want code with a leading or trailing space to throw a parse error.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working