Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: FastIsostasy v0.2.0 #96054

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Nov 28, 2023

## Breaking change
- `SolverOptions` was introduced to specify options and replaces a number of keyword arguments normally provided directly to `FastIsoProblem`.
- Running interactive sea level requires a mask to prevent changes of the load column close to the boundary of the domain.
- To make sure that the elastic and geoid response are saved in the output for a step-wise forcing, one needs to provide an additional time step. For instance: `t = [-1e-8, 0, 50_000]` for a forcing that starts at zero and a simulation that ends at 50 kyr.
- Anything related to time-variable viscosity was removed, since we have no idea of the evolution of viscosity over time.

## Improvements
- Support of fully interactive sea level with absolute ice thickness, bathymetry... etc.
- Data loaders for most of the data required to run a simulation.
- Generic boundary conditions which minimise memory allocation on GPU and CPU.
- `InplaceConvolution` internally allows to reduce the memory allocation (which was critical for high-resolution runs).
- Type instabilities of `dudt_isostasy` were fixed, code is faster than ever!
- Piecewise linear approximation of ocean surface falls back to piecewise constant approximation if does not converge. Robust and sensible output (however impossible to benchmark so far...)

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

UUID: 80efc11e-3694-4407-a4bf-24e5955cde3d
Repo: https://github.com/JanJereczek/FastIsostasy.jl.git
Tree: 3608a514fc0453337a8d2edc38945e2c8a780377

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-fastisostasy-80efc11e-v0.2.0-7c5c00fdb8 branch from eb631b1 to d16034b Compare December 21, 2023 14:34
@JuliaTagBot JuliaTagBot merged commit 8d04055 into master Dec 21, 2023
10 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-fastisostasy-80efc11e-v0.2.0-7c5c00fdb8 branch December 21, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants