This repository has been archived by the owner on May 4, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Deprecate rep(), head() and tail() #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any comments? |
I'll merge in a few days if nobody objects. |
+1 to this |
These are too general to live in DataArrays.jl, and their definition is very short.
This package is not the place for utilities functions. Most cases are supported by repeat(). rep(::AbstractVector, ::AbstractVector) has no replacement currently, but it is a less common form and should be moved to Julia Base or another package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is not the place for utilities functions. Most cases
are supported by repeat(). rep(::AbstractVector, ::AbstractVector)
has no replacement currently, but it is a less common form and
should be moved to Julia Base or another package.
I'm trying to clean up DataFrames, and it extends this function. I figured we'd better prompt people to use Base's
repeat
ASAP. Thoughrepeat
does not supportAbstractArrays
until JuliaLang/julia#14082 is merged and backported, which is why I kept the existing functions instead of calling it.I don't know what to do about
rep(::AbstractVector, ::AbstractVector)
: should Base offer this feature viarepeat
? Or via another function? Should it go to a utilities package?