Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

Deprecate rep(), head() and tail() #186

Merged
merged 2 commits into from
May 25, 2016
Merged

Deprecate rep(), head() and tail() #186

merged 2 commits into from
May 25, 2016

Conversation

nalimilan
Copy link
Member

This package is not the place for utilities functions. Most cases
are supported by repeat(). rep(::AbstractVector, ::AbstractVector)
has no replacement currently, but it is a less common form and
should be moved to Julia Base or another package.

I'm trying to clean up DataFrames, and it extends this function. I figured we'd better prompt people to use Base's repeat ASAP. Though repeat does not support AbstractArrays until JuliaLang/julia#14082 is merged and backported, which is why I kept the existing functions instead of calling it.

I don't know what to do about rep(::AbstractVector, ::AbstractVector): should Base offer this feature via repeat? Or via another function? Should it go to a utilities package?

@coveralls
Copy link

coveralls commented May 13, 2016

Coverage Status

Coverage decreased (-1.4%) to 82.693% when pulling 878aad7 on nl/rep into 44192cf on master.

@nalimilan nalimilan changed the title Deprecate rep() Deprecate rep(), head() and tail() May 13, 2016
@coveralls
Copy link

coveralls commented May 13, 2016

Coverage Status

Coverage decreased (-1.4%) to 82.676% when pulling 1c48dee on nl/rep into 44192cf on master.

@nalimilan
Copy link
Member Author

Any comments?

@coveralls
Copy link

coveralls commented May 15, 2016

Coverage Status

Coverage decreased (-1.2%) to 70.244% when pulling 213a3ba on nl/rep into 3d53fbc on master.

@nalimilan
Copy link
Member Author

I'll merge in a few days if nobody objects.

@johnmyleswhite
Copy link
Member

+1 to this

@coveralls
Copy link

coveralls commented May 25, 2016

Coverage Status

Coverage decreased (-0.6%) to 70.755% when pulling 3e00ab9 on nl/rep into 1b9f92f on master.

nalimilan added 2 commits May 25, 2016 23:02
These are too general to live in DataArrays.jl, and their
definition is very short.
This package is not the place for utilities functions. Most cases
are supported by repeat(). rep(::AbstractVector, ::AbstractVector)
has no replacement currently, but it is a less common form and
should be moved to Julia Base or another package.
@coveralls
Copy link

coveralls commented May 25, 2016

Coverage Status

Coverage decreased (-0.6%) to 70.755% when pulling 012b64b on nl/rep into 1b9f92f on master.

@nalimilan nalimilan merged commit 70490f7 into master May 25, 2016
@nalimilan nalimilan deleted the nl/rep branch May 25, 2016 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants