Fix Julia 1.0 compatibility #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 56.60% 48.98% -7.62%
==========================================
Files 13 13
Lines 530 445 -85
==========================================
- Hits 300 218 -82
+ Misses 230 227 -3
Continue to review full report at Codecov.
|
|
@nalimilan This bugfix and the follow-up PR are ready for review 🙂 |
nalimilan
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Julia 1.0 compatibility by reverting #113 and fixing some test tolerances.
I don't think there is a good way to fix Julia 1.0 compatibility without reverting that PR since only SpecialFunctions 0.8 supports Julia 1.0 but many fixes in more recent SpecialFunctions versions are required. E.g.,
gamma_inc_invcontains an undefined variablerin SpecialFunctions 0.8, i.e., fixing this problem would require us to reimplementgamma_inc_invin StatsFuns.#113 will be reapplied and released as part of StatsFuns 0.10.0 for Julia >= 1.3 and recent versions of SpecialFunctions.
Fixes #136.