Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unncessary task_local_storage entries in kernel execution. #28

Closed
arhik opened this issue Mar 28, 2024 · 2 comments · Fixed by #29
Closed

unncessary task_local_storage entries in kernel execution. #28

arhik opened this issue Mar 28, 2024 · 2 comments · Fixed by #29
Assignees
@arhik
Milestone
Performance itera...

Comments

@arhik
Copy link
Member

arhik commented Mar 28, 2024

WGPUCompute.jl/src/compiler/execution.jl

Lines 105 to 110 in 176e3dd

task_local_storage((nameof(f), :bindings, eltype.(args), getSize.(args)), bindings)
task_local_storage((nameof(f), :bindinglayouts, eltype.(args), getSize.(args)), bindingLayouts)
task_local_storage((nameof(f), :layout, eltype.(args), getSize.(args)), pipelineLayout)
task_local_storage((nameof(f), :pipeline, eltype.(args), getSize.(args)), computePipeline)
task_local_storage((nameof(f), :bindgroup, eltype.(args), getSize.(args)), pipelineLayout.bindGroup)
task_local_storage((nameof(f), :computestage, eltype.(args), getSize.(args)), computeStage)

These will also slowdown kernel execution.
@arhik
Copy link
Member Author

arhik commented Mar 28, 2024

related to #27

@arhik arhik self-assigned this Mar 28, 2024
@arhik arhik moved this to Todo in Performance tracking Mar 28, 2024
@arhik arhik added this to the Performance iteration1 milestone Mar 28, 2024
arhik added a commit to arhik/WGPUCompute.jl that referenced this issue Mar 28, 2024
@arhik
removing unncessary task_local_storage entries in kernel execution
be97500 
JuliaWGPU#28
@arhik arhik mentioned this issue Mar 28, 2024
Merged
@arhik arhik closed this as completed in #29 Mar 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Performance tracking Mar 28, 2024
@arhik
Copy link
Member Author

arhik commented Mar 29, 2024 •
edited
Loading

Screenshot 2024-03-28 at 2 00 23 PM

There is a three fold performance improvement by removing task local storage lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arhik arhik

Labels
None yet
Projects
Performance tracking
Status: Done
Milestone
Performance iteration1
1 participant
@arhik