Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full theme switcher #1

Open
JulianCataldo opened this issue Jul 20, 2022 · 2 comments · May be fixed by #9
Open

Full theme switcher #1

JulianCataldo opened this issue Jul 20, 2022 · 2 comments · May be fixed by #9
Labels
feature New feature or request

Comments

@JulianCataldo
Copy link
Owner

JulianCataldo commented Jul 20, 2022

Goal is to support this kind of setup:

  • default theme (light)
  • default theme (dark)
  • second theme (no color variant)
  • third theme (light)
  • third theme (dark)

With LocalStorage setting persistence and a toggling mechanism

@JulianCataldo JulianCataldo added the feature New feature or request label Jul 20, 2022
@JulianCataldo JulianCataldo linked a pull request Jul 24, 2022 that will close this issue
@ollebergkvist
Copy link

@JulianCataldo

Any chance of adding tailwind support? :)

@JulianCataldo
Copy link
Owner Author

JulianCataldo commented Sep 15, 2022

Hello @ollebergkvist !

I don't use Tailwind myself, as a "bare" SCSS fan.
Motivation of this project is future-proofing generic, low-levels web patterns, with minimal dependencies.
I'm pretty sure SCSS will still be widely used in 10 years, while Tailwind might probably get 2 or 3 contenders in the meanwhile, it's not the same pace (and that's good!).
Also, more personally, I feel constrained by Tailwind, even if I understand the appeal of higher level styles macros.

Still, people could build whatever they want as a design system on top of these headless components.
But I'm totally open to facilitate its usage for, say, the color mode switcher (?).
Tell me if you want some API to be implemented for seamless Tailwind usage, and we will see.

TL;DR: Most of my in-page components are extending the generic Astro HTMLElement, so you should get auto-completion with class or class:list array, and pass your own Tailwind styles.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants