Syncd graceful shutdown should not be ignored #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazariig
approved these changes
Mar 1, 2023
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 15, 2023
…nux-kernel] advance submodule head (sonic-net#13906) linkmgrd: * 3e7a9df 2023-02-19 | [active-active] Toggle to standby if default route is missing (#171) (HEAD -> 202205) [Longxiang Lyu] * 8ab1b2b 2023-02-15 | [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (#169) [Jing Zhang] * df862ad 2023-02-11 | Fix mux config when gRPC connection is lost (#166) [Longxiang Lyu] utilities: * 8aa7930c 2023-02-13 | [portstat CLI] don't print reminder if use json format (sonic-net#2670) (HEAD -> 202205, github/202205) [wenyiz2021] * 4e3bb6fa 2023-02-21 | Add "show fabric reachability" command. (sonic-net#2672) [jfeng-arista] * 3587a94b 2023-02-18 | [202205][dhcp_relay] Remove add field of vlanid to DHCP_RELAY table while adding vlan (sonic-net#2680) [Yaqiang Zhu] * 4f07f7f0 2023-02-10 | Skip saidump for Spine Router as this can take more than 5 sec (sonic-net#2637) (sonic-net#2671) [kenneth-arista] * e61c5ec4 2023-02-10 | [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (sonic-net#2660) (sonic-net#2669) [Yaqiang Zhu] swss: * 1bbf725 2023-02-14 | [Workaround] EvpnRemoteVnip2pOrch warmboot check failure (sonic-net#2626) (HEAD -> 202205) [jcaiMR] * 380f72b 2023-02-20 | Support for tc-dot1p and tc-dscp qosmap (sonic-net#2559) [Divya Mukundan] * dbf6fcc 2022-11-01 | Added LAG member check on addLagMember() (sonic-net#2464) [Andriy Kokhan] swss-common: * b31391b 2023-02-21 | Prevent sonic-db-cli generate core dump (sonic-net#749) (HEAD -> 202205) [Hua Liu] * 16ff689 2022-12-13 | Support for TC-DOT1p qos map (sonic-net#721) [Divya Mukundan] platform-daemons: * fb92af4 2023-02-09 | [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (sonic-net#338) (HEAD -> 202205) [vdahiya12] linux-kernel: * 4e62401 2023-02-09 | Update linux kernel for hw-mgmt V.7.0020.4104 (sonic-net#305) (HEAD -> 202205) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jul 14, 2023
sonic-net#15576) #### Why I did it src/linkmgrd ``` * fc6e299 - (HEAD -> 202211, origin/202211) [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (#184) (2 hours ago) [Jing Zhang] * 5c6332d - Re-handle pre-init mux config notification after state machine init (#202) (2 hours ago) [Longxiang Lyu] * c49a5ef - [active-standby][bsl] fix no mux probe issue (#201) (2 hours ago) [Jing Zhang] * 2d62ef1 - Enable debug symbols (#199) (2 hours ago) [Longxiang Lyu] * f952b64 - [active-active] Add mux server state correction mechanism (#191) (2 hours ago) [Longxiang Lyu] * e6b1bfc - [ci] fix azure pipeline (#190) (2 hours ago) [Jing Zhang] * 615ed21 - [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (#184) (2 hours ago) [Jing Zhang] * 3adfc69 - [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (#179) (2 hours ago) [Jing Zhang] * 6fb9a0b - loose link down swithcover condition (#178) (2 hours ago) [Jing Zhang] * 8ffbd8a - [ci] Fix apt-get install unable locate package issue. (#177) (2 hours ago) [Liu Shilong] * 3dfbdd7 - [active-active] link operational down didn't trigger toggle to standby if `MuxUnknown` event arrives first. (#175) (2 hours ago) [Jing Zhang] * 68c06d9 - [active-active] Toggle to standby if default route is missing (#171) (2 hours ago) [Longxiang Lyu] * 1592cd3 - [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (#169) (2 hours ago) [Jing Zhang] * a96105f - Fix the warning of unused variables (#167) (2 hours ago) [Longxiang Lyu] * 984ffe3 - Fix mux config when gRPC connection is lost (#166) (2 hours ago) [Longxiang Lyu] * 4d0b457 - [active-active] force switch when config == active && target state == active (#164) (2 hours ago) [Jing Zhang] * 32bd2bb - Use github code scanning instead of LGTM (#157) (2 hours ago) [Liu Shilong] * 6f23fe2 - [active-active] update linkmgr health label definition (#163) (3 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Dec 11, 2024
…utomatically (sonic-net#20746) #### Why I did it src/sonic-host-services ``` * ff73070 - (HEAD -> master, origin/master, origin/HEAD) Add execute_reboot dbus_interface (#164) (4 days ago) [Vasundhara Volam] * fec6080 - DBUS API for GNOI System.SetPackage (#171) (4 days ago) [Dawei Huang] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did this?
Due to a limitation in mellanox platform, sonic ignores syncs graceful shutdown in syncd.sh previously. However, ignoring graceful shutdown in syncd.sh also ignores closing other resources such as removing all counters.
This PR changes syncd shutdown flow for mellanox platform to make sure it execute graceful shutdown flow. There is another PR for sonic-sairedis to make sure mellanox platform does not call remove_switch for cold shutdown.
How I test this?
Running config reload on many platforms and check result.