Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decaffeinate lib/runtime and lib/ui #755

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

aminya
Copy link

@aminya aminya commented Jun 8, 2020

Should be merged after its children #761 #763 #760 #762

I analyzed these:

File
    ui.js
Found usages  (10 usages found)
    Unclassified usage  (6 usages found)
        lib\runtime  (6 usages found)
            console.js  (1 usage found)
                11 import { selector } from '../ui'
            debugger.js  (1 usage found)
                5 import { views } from '../ui'
            frontend.js  (1 usage found)
                4 import { selector, notifications } from '../ui'
            packages.js  (1 usage found)
                4 import { selector } from '../ui'
            plots.js  (1 usage found)
                4 import { views } from '../ui'
            urihandler.js  (1 usage found)
                4 import { docpane, views } from '../ui'
    Usage in string literals  (4 usages found)
        lib  (1 usage found)
            julia-client.coffee  (1 usage found)
                20 ui:         require './ui'
        lib\runtime  (2 usages found)
            evaluation.coffee  (1 usage found)
                6 {notifications, views, selector, docpane} = require '../ui'
            workspace.coffee  (1 usage found)
                4 {views} = require '../ui'
        lib\ui  (1 usage found)
            layout.js  (1 usage found)
                documentation  (1 usage found)
                    10 return require('../ui').docpane
@aminya aminya mentioned this pull request Jun 8, 2020
@aminya aminya changed the title decaffeinate lib/runtime decaffeinate lib/runtime and lib/ui Jun 8, 2020
@aminya
Copy link
Author

aminya commented Jun 8, 2020

I merged #756 here. Because of the circular dependencies, there is no way to fix this in separate PRs.

@aminya aminya marked this pull request as draft June 8, 2020 12:42
@aminya aminya force-pushed the decaf-runtime branch 2 times, most recently from 2f834b4 to d2d67fb Compare June 8, 2020 13:14
@aminya aminya marked this pull request as ready for review June 8, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant