Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lease choices a GraphQL enum #142

Open
toolness opened this issue Sep 13, 2018 · 0 comments
Open

Make lease choices a GraphQL enum #142

toolness opened this issue Sep 13, 2018 · 0 comments

Comments

@toolness
Copy link
Collaborator

toolness commented Sep 13, 2018

When working on #138 and #139, I noticed that the mail choices actually make their way to globalTypes.ts as an enum, unlike our other choices. I think this is because we expose the LetterRequest model to GraphQL via Graphene's DjangoObjectType class, which I've never used before, and I think that contrary to the other class we've been using, DjangoFormMutation, it actually represents choices as GraphQL enums.

It would be nice if we could do this with the lease choices in particular, as we hard-code them in onboarding step 3.

Update: It would also be helpful if borough choices were a GraphQL enum too; I had to manually define them as a TS enum in #192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant