Suffix Exceptions with "Exception"

core/api/core.api

@@ -77,7 +77,7 @@ public abstract interface class com/juul/able/device/Device {
 	public abstract fun connectGatt (Landroid/content/Context;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 }
 
-public final class com/juul/able/gatt/ConnectionLost : java/io/IOException {
+public final class com/juul/able/gatt/ConnectionLostException : java/io/IOException {
 	public fun <init> ()V
 }
 
@@ -109,7 +109,7 @@ public abstract interface class com/juul/able/gatt/GattConnection {
 	public abstract fun getOnConnectionStateChange ()Lkotlinx/coroutines/flow/Flow;
 }
 
-public final class com/juul/able/gatt/GattErrorStatus : java/io/IOException {
+public final class com/juul/able/gatt/GattErrorStatusException : java/io/IOException {
 	public final fun getEvent ()Lcom/juul/able/gatt/OnConnectionStateChange;
 }
 
@@ -242,7 +242,7 @@ public final class com/juul/able/gatt/OnReadRemoteRssi : com/juul/able/gatt/HasG
 	public fun toString ()Ljava/lang/String;
 }
 
-public final class com/juul/able/gatt/OutOfOrderGattCallback : java/io/IOException {
+public final class com/juul/able/gatt/OutOfOrderGattCallbackException : java/io/IOException {
 }
 
 public final class com/juul/able/logger/AndroidLogger : com/juul/able/logger/Logger {

core/src/main/java/device/CoroutinesDevice.kt

@@ -13,11 +13,11 @@ import android.os.RemoteException
 import com.juul.able.Able
 import com.juul.able.device.ConnectGattResult.Failure
 import com.juul.able.device.ConnectGattResult.Success
-import com.juul.able.gatt.ConnectionLost
+import com.juul.able.gatt.ConnectionLostException
 import com.juul.able.gatt.CoroutinesGatt
 import com.juul.able.gatt.GattCallback
 import com.juul.able.gatt.GattConnection
-import com.juul.able.gatt.GattErrorStatus
+import com.juul.able.gatt.GattErrorStatusException
 import com.juul.able.gatt.asGattConnectionStateString
 import kotlinx.coroutines.CancellationException
 import kotlinx.coroutines.flow.first
@@ -60,8 +60,8 @@ internal class CoroutinesDevice(
         onConnectionStateChange
             .onEach { event ->
                 Able.verbose { "← Device $device received $event while waiting for connection" }
-                if (event.status != GATT_SUCCESS) throw GattErrorStatus(event)
-                if (event.newState == STATE_DISCONNECTED) throw ConnectionLost()
+                if (event.status != GATT_SUCCESS) throw GattErrorStatusException(event)
+                if (event.newState == STATE_DISCONNECTED) throw ConnectionLostException()
             }
             .first { (_, newState) -> newState == STATE_CONNECTED }
             .also { (_, newState) ->

core/src/main/java/gatt/CoroutinesGatt.kt

@@ -24,7 +24,7 @@ import kotlinx.coroutines.sync.Mutex
 import kotlinx.coroutines.sync.withLock
 import kotlinx.coroutines.withContext
 
-class OutOfOrderGattCallback internal constructor(message: String) : IOException(message)
+class OutOfOrderGattCallbackException internal constructor(message: String) : IOException(message)
 
 class CoroutinesGatt internal constructor(
     private val bluetoothGatt: BluetoothGatt,
@@ -118,15 +118,15 @@ class CoroutinesGatt internal constructor(
         } catch (e: CancellationException) {
             throw CancellationException("Waiting on response for $methodName was cancelled", e)
         } catch (e: Exception) {
-            throw ConnectionLost("Failed to receive response for $methodName", e)
+            throw ConnectionLostException("Failed to receive response for $methodName", e)
         }
         Able.info { "$methodName ← $response" }
 
         // `lock` should always enforce a 1:1 matching of request to response, but if an Android
         // `BluetoothGattCallback` method gets called out of order then we'll cast to the wrong
         // response type.
         response as? T
-            ?: throw OutOfOrderGattCallback(
+            ?: throw OutOfOrderGattCallbackException(
                 "Unexpected response type ${response.javaClass.simpleName} received for $methodName"
             )
     }
@@ -139,7 +139,7 @@ class CoroutinesGatt internal constructor(
                     val device = bluetoothGatt.device
                     "← Device $device received $event while waiting for disconnection"
                 }
-                if (event.status != GATT_SUCCESS) throw GattErrorStatus(event)
+                if (event.status != GATT_SUCCESS) throw GattErrorStatusException(event)
             }
             .first { (_, newState) -> newState == STATE_DISCONNECTED }
             .also { (_, newState) ->

core/src/main/java/gatt/GattCallback.kt

@@ -38,7 +38,7 @@ internal class GattCallback(
 
     private fun onDisconnecting() {
         onCharacteristicChanged.close()
-        onResponse.close(ConnectionLost())
+        onResponse.close(ConnectionLostException())
     }
 
     fun close(gatt: BluetoothGatt) {

core/src/main/java/gatt/GattConnection.kt

@@ -45,11 +45,11 @@ interface GattConnection {
     suspend fun disconnect(): Unit
 }
 
-class GattErrorStatus internal constructor(
+class GattErrorStatusException internal constructor(
     val event: OnConnectionStateChange
 ) : IOException("Received $event")
 
-class ConnectionLost internal constructor(
+class ConnectionLostException internal constructor(
     message: String? = null,
     cause: Throwable? = null
 ) : IOException(message, cause)

core/src/main/java/gatt/GattIo.kt

@@ -43,7 +43,7 @@ interface GattIo {
 
     /**
      * @throws [RemoteException] if underlying [BluetoothGatt.discoverServices] returns `false`.
-     * @throws [ConnectionLost] if [Gatt] disconnects while method is executing.
+     * @throws [ConnectionLostException] if [Gatt] disconnects while method is executing.
      */
     suspend fun discoverServices(): GattStatus
 
@@ -55,13 +55,13 @@ interface GattIo {
 
     /**
      * @throws [RemoteException] if underlying [BluetoothGatt.requestMtu] returns `false`.
-     * @throws [ConnectionLost] if [Gatt] disconnects while method is executing.
+     * @throws [ConnectionLostException] if [Gatt] disconnects while method is executing.
      */
     suspend fun requestMtu(mtu: Int): OnMtuChanged
 
     /**
      * @throws [RemoteException] if underlying [BluetoothGatt.readCharacteristic] returns `false`.
-     * @throws [ConnectionLost] if [Gatt] disconnects while method is executing.
+     * @throws [ConnectionLostException] if [Gatt] disconnects while method is executing.
      */
     suspend fun readCharacteristic(
         characteristic: BluetoothGattCharacteristic
@@ -71,7 +71,7 @@ interface GattIo {
      * @param value applied to [characteristic] when characteristic is written.
      * @param writeType applied to [characteristic] when characteristic is written.
      * @throws [RemoteException] if underlying [BluetoothGatt.writeCharacteristic] returns `false`.
-     * @throws [ConnectionLost] if [Gatt] disconnects while method is executing.
+     * @throws [ConnectionLostException] if [Gatt] disconnects while method is executing.
      */
     suspend fun writeCharacteristic(
         characteristic: BluetoothGattCharacteristic,
@@ -82,7 +82,7 @@ interface GattIo {
     /**
      * @param value applied to [descriptor] when descriptor is written.
      * @throws [RemoteException] if underlying [BluetoothGatt.writeDescriptor] returns `false`.
-     * @throws [ConnectionLost] if [Gatt] disconnects while method is executing.
+     * @throws [ConnectionLostException] if [Gatt] disconnects while method is executing.
      */
     suspend fun writeDescriptor(
         descriptor: BluetoothGattDescriptor,
@@ -96,7 +96,7 @@ interface GattIo {
 
     /**
      * @throws [RemoteException] if underlying [BluetoothGatt.requestMtu] returns `false`.
-     * @throws [ConnectionLost] if [Gatt] disconnects while method is executing.
+     * @throws [ConnectionLostException] if [Gatt] disconnects while method is executing.
      */
     suspend fun readRemoteRssi(): OnReadRemoteRssi
 }

core/src/test/java/device/CoroutinesDeviceTest.kt

@@ -16,10 +16,10 @@ import com.juul.able.device.ConnectGattResult
 import com.juul.able.device.ConnectGattResult.Failure
 import com.juul.able.device.ConnectGattResult.Success
 import com.juul.able.device.CoroutinesDevice
-import com.juul.able.gatt.ConnectionLost
+import com.juul.able.gatt.ConnectionLostException
 import com.juul.able.gatt.GATT_CONN_CANCEL
 import com.juul.able.gatt.GattCallback
-import com.juul.able.gatt.GattErrorStatus
+import com.juul.able.gatt.GattErrorStatusException
 import com.juul.able.gatt.OnConnectionStateChange
 import com.juul.able.test.logger.ConsoleLoggerTestRule
 import io.mockk.every
@@ -65,7 +65,7 @@ class CoroutinesDeviceTest {
 
         assertEquals(
             expected = OnConnectionStateChange(GATT_CONN_CANCEL, STATE_CONNECTED),
-            actual = (failure.cause as GattErrorStatus).event
+            actual = (failure.cause as GattErrorStatusException).event
         )
         verify(exactly = 1) { bluetoothGatt.close() }
     }
@@ -120,7 +120,7 @@ class CoroutinesDeviceTest {
         val failure = device.connectGatt(mockk()) as Failure.Connection
 
         assertEquals<Class<out Throwable>>(
-            expected = ConnectionLost::class.java,
+            expected = ConnectionLostException::class.java,
             actual = failure.cause.javaClass
         )
         verify(exactly = 1) { bluetoothGatt.close() }

core/src/test/java/gatt/CoroutinesGattTest.kt

@@ -14,15 +14,15 @@ import android.bluetooth.BluetoothProfile.STATE_CONNECTED
 import android.bluetooth.BluetoothProfile.STATE_DISCONNECTED
 import android.bluetooth.BluetoothProfile.STATE_DISCONNECTING
 import android.os.RemoteException
-import com.juul.able.gatt.ConnectionLost
+import com.juul.able.gatt.ConnectionLostException
 import com.juul.able.gatt.CoroutinesGatt
 import com.juul.able.gatt.GattCallback
 import com.juul.able.gatt.OnCharacteristicChanged
 import com.juul.able.gatt.OnCharacteristicRead
 import com.juul.able.gatt.OnCharacteristicWrite
 import com.juul.able.gatt.OnDescriptorWrite
 import com.juul.able.gatt.OnReadRemoteRssi
-import com.juul.able.gatt.OutOfOrderGattCallback
+import com.juul.able.gatt.OutOfOrderGattCallbackException
 import com.juul.able.gatt.writeCharacteristic
 import com.juul.able.test.gatt.FakeBluetoothGattCharacteristic as FakeCharacteristic
 import com.juul.able.test.gatt.FakeBluetoothGattDescriptor as FakeDescriptor
@@ -357,7 +357,7 @@ class CoroutinesGattTest {
 
             val gatt = CoroutinesGatt(bluetoothGatt, dispatcher, callback)
             runBlocking {
-                assertFailsWith<OutOfOrderGattCallback> {
+                assertFailsWith<OutOfOrderGattCallbackException> {
                     gatt.readCharacteristic(createCharacteristic())
                 }
             }
@@ -475,7 +475,7 @@ class CoroutinesGattTest {
     }
 
     @Test
-    fun `Gatt action throws ConnectionLost if connection drops while executing request`() {
+    fun `Gatt action throws ConnectionLostException if connection drops while executing request`() {
         createDispatcher().use { dispatcher ->
             val callback = GattCallback(dispatcher)
             val bluetoothGatt = mockk<BluetoothGatt> {
@@ -489,12 +489,12 @@ class CoroutinesGattTest {
 
             val gatt = CoroutinesGatt(bluetoothGatt, dispatcher, callback)
             runBlocking {
-                val cause = assertFailsWith<ConnectionLost> {
+                val cause = assertFailsWith<ConnectionLostException> {
                     gatt.readCharacteristic(createCharacteristic())
                 }.cause
 
                 assertEquals<Class<out Throwable>>(
-                    expected = ConnectionLost::class.java,
+                    expected = ConnectionLostException::class.java,
                     actual = cause!!.javaClass
                 )
             }

keep-alive/README.md

@@ -124,12 +124,12 @@ gatt.state.collect { println("State: $it") }
 
 If a Gatt operation (e.g. `discoverServices`, `writeCharacteristic`, `readCharacteristic`, etc) is
 unable to be performed due to a GATT connection being unavailable (i.e. current `State` is **not**
-`Connected`), then it will immediately throw `NotReady`.
+`Connected`), then it will immediately throw `NotReadyException`.
 
 It is the responsibility of the caller to handle retrying, for example:
 
 ```kotlin
-class GattCancelled : Exception()
+class GattCancelledException : Exception()
 
 suspend fun KeepAliveGatt.readCharacteristicWithRetry(
     characteristic: BluetoothGattCharacteristic,
@@ -148,7 +148,7 @@ suspend fun KeepAliveGatt.readCharacteristicWithRetry(
 
 private suspend fun KeepAliveGatt.suspendUntilConnected() {
     state
-        .onEach { if (it is Cancelled) throw GattCancelled() }
+        .onEach { if (it is Cancelled) throw GattCancelledException() }
         .first { it == Connected }
 }
 ```

keep-alive/api/keep-alive.api

@@ -75,7 +75,7 @@ public final class com/juul/able/keepalive/KeepAliveGattKt {
 	public static synthetic fun keepAliveGatt$default (Lkotlinx/coroutines/CoroutineScope;Landroid/content/Context;Landroid/bluetooth/BluetoothDevice;JLkotlin/jvm/functions/Function2;ILjava/lang/Object;)Lcom/juul/able/keepalive/KeepAliveGatt;
 }
 
-public final class com/juul/able/keepalive/NotReady : java/lang/IllegalStateException {
+public final class com/juul/able/keepalive/NotReadyException : java/lang/IllegalStateException {
 }
 
 public abstract class com/juul/able/keepalive/State {

keep-alive/src/main/java/KeepAliveGatt.kt

@@ -50,7 +50,7 @@ import kotlinx.coroutines.supervisorScope
 import kotlinx.coroutines.withContext
 import kotlinx.coroutines.withTimeoutOrNull
 
-class NotReady internal constructor(message: String) : IllegalStateException(message)
+class NotReadyException internal constructor(message: String) : IllegalStateException(message)
 
 typealias EventHandler = suspend (Event) -> Unit
 
@@ -92,7 +92,7 @@ class KeepAliveGatt internal constructor(
     @Volatile
     private var _gatt: GattIo? = null
     private val gatt: GattIo
-        inline get() = _gatt ?: throw NotReady(toString())
+        inline get() = _gatt ?: throw NotReadyException(toString())
 
     private val _state = MutableStateFlow<State>(State.Disconnected())
 

keep-alive/src/test/java/KeepAliveGattTest.kt

@@ -15,12 +15,12 @@ import com.juul.able.Able
 import com.juul.able.android.connectGatt
 import com.juul.able.device.ConnectGattResult
 import com.juul.able.device.ConnectGattResult.Failure
-import com.juul.able.gatt.ConnectionLost
+import com.juul.able.gatt.ConnectionLostException
 import com.juul.able.gatt.Gatt
 import com.juul.able.gatt.OnCharacteristicChanged
 import com.juul.able.gatt.OnReadRemoteRssi
 import com.juul.able.keepalive.Event
-import com.juul.able.keepalive.NotReady
+import com.juul.able.keepalive.NotReadyException
 import com.juul.able.keepalive.State
 import com.juul.able.keepalive.State.Connected
 import com.juul.able.keepalive.State.Connecting
@@ -192,14 +192,14 @@ class KeepAliveGattTest {
     }
 
     @Test
-    fun `Bluetooth IO when not connected throws NotReady`() = runBlocking<Unit> {
+    fun `Bluetooth IO when not connected throws NotReadyException`() = runBlocking<Unit> {
         val keepAlive = GlobalScope.keepAliveGatt(
             androidContext = mockk(relaxed = true),
             bluetoothDevice = mockk(),
             disconnectTimeoutMillis = DISCONNECT_TIMEOUT
         )
 
-        assertFailsWith<NotReady> {
+        assertFailsWith<NotReadyException> {
             keepAlive.discoverServices()
         }
     }
@@ -220,7 +220,7 @@ class KeepAliveGattTest {
                 bluetoothDevice.connectGatt(any())
             } answers {
                 if (++attempt >= connectionAttempts) throw EndOfTest()
-                Failure.Connection(mockk<ConnectionLost>())
+                Failure.Connection(mockk<ConnectionLostException>())
             }
 
             val keepAlive = scope.keepAliveGatt(
@@ -616,7 +616,7 @@ class KeepAliveGattTest {
                 bluetoothDevice.connectGatt(any())
             } answers {
                 if (++attempt > connectionAttempts) throw EndOfTest()
-                Failure.Connection(mockk<ConnectionLost>())
+                Failure.Connection(mockk<ConnectionLostException>())
             }
 
             val events = mutableListOf<Event>()

throw/src/main/java/android/BluetoothDeviceOrThrow.kt

@@ -12,14 +12,14 @@ import android.os.RemoteException
 import com.juul.able.android.connectGatt
 import com.juul.able.device.ConnectGattResult.Failure
 import com.juul.able.device.ConnectGattResult.Success
-import com.juul.able.gatt.ConnectionLost
+import com.juul.able.gatt.ConnectionLostException
 import com.juul.able.gatt.Gatt
-import com.juul.able.gatt.GattErrorStatus
+import com.juul.able.gatt.GattErrorStatusException
 
 /**
  * @throws RemoteException if underlying [BluetoothDevice.connectGatt] returns `null`.
- * @throws GattErrorStatus if non-[GATT_SUCCESS] status is received during connection process.
- * @throws ConnectionLost if [STATE_DISCONNECTED] is received during connection process.
+ * @throws GattErrorStatusException if non-[GATT_SUCCESS] status is received during connection process.
+ * @throws ConnectionLostException if [STATE_DISCONNECTED] is received during connection process.
  */
 suspend fun BluetoothDevice.connectGattOrThrow(
     context: Context