Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct order in LandingPageModel #4

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Correct order in LandingPageModel #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
791c6f7
Correct order in LandingPageModel
lukas-phaf Oct 26, 2023
4b7297f
Bump version and update README with related projects.
lukas-phaf Oct 26, 2023
8957245
Fix test.
lukas-phaf Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ pytest tests/

This library is used to build an Environmental Data Retrieval (EDR) API, serving observation data from surface weather data station data from the KNMI. See the [KNMI Data Platform](https://developer.dataplatform.knmi.nl/edr-api).

## Related projects
* [CoverageJSON Pydantic](https://github.com/KNMI/covjson-pydantic)
* [geojson-pydantic](https://github.com/developmentseed/geojson-pydantic)

## TODOs
Help is wanted in the following areas to fully implement the EDR spec:
* See TODOs in code listing various small inconsistencies in the spec
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ classifiers = [
"Topic :: Scientific/Engineering :: GIS",
"Typing :: Typed",
]
version = "0.2.0"
version = "0.2.1"
dependencies = ["pydantic>=2.3,<3"]

[project.optional-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion src/edr_pydantic/capabilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ class Contact(EdrBaseModel):


class LandingPageModel(EdrBaseModel):
links: List[Link]
title: Optional[str] = None
description: Optional[str] = None
links: List[Link]
keywords: Optional[List[str]] = None
provider: Optional[Provider] = None
contact: Optional[Contact] = None
Expand Down
4 changes: 2 additions & 2 deletions tests/test_data/landing-page.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{
"title": "Observations API EDR",
"description": "The observation api in EDR format from the KNMI",
"links": [
{
"href": "https://api.dataplatform.knmi.nl/edr/",
Expand Down Expand Up @@ -26,8 +28,6 @@
"title": "Collections metadata in JSON"
}
],
"title": "Observations API EDR",
"description": "The observation api in EDR format from the KNMI",
"keywords": [
"Weather",
"Temperature",
Expand Down