From ee8406772c80755da3f430af2286ecd2e276d862 Mon Sep 17 00:00:00 2001 From: Kingkor Roy Tirtho Date: Wed, 18 Sep 2024 10:12:15 +0600 Subject: [PATCH 1/4] chore: add webkit2gtk-4.1 as AUR dependency --- aur-struct/.SRCINFO | 1 + aur-struct/PKGBUILD | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/aur-struct/.SRCINFO b/aur-struct/.SRCINFO index 29eedf742..4c07a0452 100644 --- a/aur-struct/.SRCINFO +++ b/aur-struct/.SRCINFO @@ -11,6 +11,7 @@ depends = libsecret depends = jsoncpp depends = libnotify depends = xdg-user-dirs +depends = webkit2gtk-4.1 source = https://github.com/KRTirtho/spotube/releases/download/v3.7.1/spotube-linux-3.7.1-x86_64.tar.xz md5sums = 475b1ae9b08f27743a4d4749391ae3db diff --git a/aur-struct/PKGBUILD b/aur-struct/PKGBUILD index 4663c3abe..d7e1052b6 100644 --- a/aur-struct/PKGBUILD +++ b/aur-struct/PKGBUILD @@ -8,7 +8,7 @@ arch=(x86_64) url="https://github.com/KRTirtho/spotube/" license=('BSD-4-Clause') groups=() -depends=('mpv' 'libappindicator-gtk3' 'libsecret' 'jsoncpp' 'libnotify' 'xdg-user-dirs') +depends=('mpv' 'libappindicator-gtk3' 'libsecret' 'jsoncpp' 'libnotify' 'xdg-user-dirs' 'webkit2gtk-4.1') makedepends=() checkdepends=() optdepends=() From 200ee4a6bd669c1da4d8caf0b878bcd5546e3fb4 Mon Sep 17 00:00:00 2001 From: Ryze <48110960+sunryze-git@users.noreply.github.com> Date: Mon, 30 Sep 2024 10:18:35 -0400 Subject: [PATCH 2/4] fix: endless song loading issue and no playback #1925 * chore: update bug reports template * chore: update bug reports template * update youtube_explode_dart dependency version --------- Co-authored-by: Kingkor Roy Tirtho --- .github/ISSUE_TEMPLATE/bug_report.yml | 30 +++++++++++++++++++++++---- pubspec.yaml | 2 +- 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index fed668501..a9c578369 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -7,8 +7,12 @@ labels: body: - type: checkboxes attributes: - label: Is there an existing issue for this? - description: Make sure to check if this issue is a duplicate. + label: Is there an existing issue for this? (Please read the description) + description: | + PLEASE! Make sure to check if this issue is a duplicate. + Don't waste our time, we are working hard to make Spotube better for you. + + Try with multiple similar keywords, and check the closed issues too. options: - label: I have searched the existing issues required: true @@ -16,23 +20,41 @@ body: attributes: label: Current Behavior description: Write what you are experiencing currently. + placeholder: | + The app isn't working as expected. It crashes when I do this... validations: required: true - type: textarea attributes: label: Expected Behavior description: Write what you expected to happen. + placeholder: | + The app should do this when I do that... validations: required: true - type: textarea attributes: label: Steps to reproduce - description: Steps to reproduce the issue. A not well written description might delay the resolve of it. + description: Steps to reproduce the issue. A not well written description might lead to the delay in fixing the issue. placeholder: | 1. I opened the app 2. I did this 3. And that 4. Then this happened + - type: textarea + attributes: + label: Logs + description: | + If you have any logs, paste them here. Make sure to remove any sensitive information. + You can find the logs in the app's Settings > Developers > Logs page. + value: | +
+ Logs + + ``` + + ``` +
validations: required: true - type: input @@ -74,7 +96,7 @@ body: - type: checkboxes attributes: label: Self grab - description: If you are a developer and want to work on this issue yourself, you can check this box and wait for maintainer response. We welcome contributions! + description: If you are a developer and want to work on this issue yourself, you can check this box and wait for maintainer response. Any contributions are welcome! options: - label: I'm ready to work on this issue! required: false diff --git a/pubspec.yaml b/pubspec.yaml index e4face3c4..e0c51cc5b 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -95,7 +95,7 @@ dependencies: version: ^3.0.2 visibility_detector: ^0.4.0+2 window_manager: ^0.3.9 - youtube_explode_dart: ^2.2.1 + youtube_explode_dart: ^2.2.2 simple_icons: ^10.1.3 jiosaavn: ^0.1.0 draggable_scrollbar: From c1f2ddcdbed4dabd3bd861a0b6a230fce710b02a Mon Sep 17 00:00:00 2001 From: Kingkor Roy Tirtho Date: Mon, 30 Sep 2024 20:51:28 +0600 Subject: [PATCH 3/4] chore: remove donation links from about page to avoid Google's imaginary "pay cut" policy strike --- lib/pages/settings/about.dart | 58 ----------------------------------- 1 file changed, 58 deletions(-) diff --git a/lib/pages/settings/about.dart b/lib/pages/settings/about.dart index 4d093cfe5..1357c52f8 100644 --- a/lib/pages/settings/about.dart +++ b/lib/pages/settings/about.dart @@ -8,7 +8,6 @@ import 'package:spotube/components/titlebar/titlebar.dart'; import 'package:spotube/extensions/context.dart'; import 'package:spotube/hooks/controllers/use_package_info.dart'; -import 'package:flutter_svg/flutter_svg.dart'; import 'package:hooks_riverpod/hooks_riverpod.dart'; import 'package:url_launcher/url_launcher.dart'; @@ -139,63 +138,6 @@ class AboutSpotube extends HookConsumerWidget { ), ), const SizedBox(height: 20), - Wrap( - runSpacing: 20, - spacing: 20, - alignment: WrapAlignment.center, - crossAxisAlignment: WrapCrossAlignment.center, - runAlignment: WrapAlignment.center, - children: [ - MouseRegion( - cursor: SystemMouseCursors.click, - child: GestureDetector( - onTap: () { - launchUrl( - Uri.parse("https://www.buymeacoffee.com/krtirtho"), - mode: LaunchMode.externalApplication, - ); - }, - child: SvgPicture.network( - "https://img.buymeacoffee.com/button-api/?text=Buy me a coffee&emoji=&slug=krtirtho&button_colour=FF5F5F&font_colour=ffffff&font_family=Inter&outline_colour=000000&coffee_colour=FFDD00", - height: 45, - ), - ), - ), - MouseRegion( - cursor: SystemMouseCursors.click, - child: GestureDetector( - onTap: () { - launchUrl( - Uri.parse( - "https://opencollective.com/spotube", - ), - mode: LaunchMode.externalApplication, - ); - }, - child: Image.network( - "https://opencollective.com/spotube/donate/button.png?color=blue", - height: 45, - ), - ), - ), - MouseRegion( - cursor: SystemMouseCursors.click, - child: GestureDetector( - onTap: () { - launchUrl( - Uri.parse("https://patreon.com/krtirtho"), - mode: LaunchMode.externalApplication, - ); - }, - child: Image.network( - "https://user-images.githubusercontent.com/61944859/180249027-678b01b8-c336-451e-b147-6d84a5b9d0e7.png", - height: 45, - ), - ), - ), - ], - ), - const SizedBox(height: 20), Text( context.l10n.made_with, textAlign: TextAlign.center, From b87a51011b199017db0f8d3c7207c25dba0b4130 Mon Sep 17 00:00:00 2001 From: Kingkor Roy Tirtho Date: Mon, 30 Sep 2024 21:56:34 +0600 Subject: [PATCH 4/4] chore: bump to v3.8.2 abd generate changelogs --- .github/workflows/spotube-publish-binary.yml | 2 +- CHANGELOG.md | 9 +++++++++ pubspec.yaml | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/spotube-publish-binary.yml b/.github/workflows/spotube-publish-binary.yml index a5ee34498..3153c279f 100644 --- a/.github/workflows/spotube-publish-binary.yml +++ b/.github/workflows/spotube-publish-binary.yml @@ -4,7 +4,7 @@ on: inputs: version: description: Version to publish (x.x.x) - default: 3.8.1 + default: 3.8.2 required: true dry_run: description: Dry run diff --git a/CHANGELOG.md b/CHANGELOG.md index 20b48c269..8297a7c4f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,15 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +## [3.8.2](https://github.com/krtirtho/spotube/compare/v3.8.0...v3.8.1) (2024-09-30) + +## Changes + +### Bug Fixes + +- endless song loading issue and no playback #1925 + + ## [3.8.1](https://github.com/krtirtho/spotube/compare/v3.8.0...v3.8.1) (2024-09-15) ## Changes diff --git a/pubspec.yaml b/pubspec.yaml index e0c51cc5b..85b7a7195 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -3,7 +3,7 @@ description: Open source Spotify client that doesn't require Premium nor uses El publish_to: "none" -version: 3.8.1+34 +version: 3.8.2+35 homepage: https://spotube.krtirtho.dev repository: https://github.com/KRTirtho/spotube