Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple test cylinder #52

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Add simple test cylinder #52

merged 5 commits into from
Sep 19, 2023

Conversation

dbruneau-mie
Copy link
Collaborator

Simple test cylinder added to repo.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #52 (6fde7a8) into master (60f344f) will increase coverage by 0.74%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   70.98%   71.72%   +0.74%     
==========================================
  Files          10       10              
  Lines        1151     1192      +41     
==========================================
+ Hits          817      855      +38     
- Misses        334      337       +3     

see 4 files with indirect coverage changes

@keiyamamo
Copy link
Collaborator

Hi @dbruneau-mie
Thanks for the update! The script still doesn’t pass the test. Just need to explicitly import functions from FEniCS instead of from dolfin import *. (see here)

src/fsipy/simulations/cylinder.py Outdated Show resolved Hide resolved
src/fsipy/simulations/cylinder.py Outdated Show resolved Hide resolved
src/fsipy/simulations/cylinder.py Outdated Show resolved Hide resolved
src/fsipy/simulations/cylinder.py Outdated Show resolved Hide resolved
src/fsipy/simulations/cylinder.py Outdated Show resolved Hide resolved
src/fsipy/simulations/cylinder.py Outdated Show resolved Hide resolved
@keiyamamo
Copy link
Collaborator

@dbruneau-mie I talked with @jorgensd about the authorship for each functions and we concluded that listing all the authors' name at the top of script is better than listing author name for each functions. If we include author name as doc-string in each functions, user will be exposed to the author name when using help(some_function) and we thought that information might not be the most critical one for the user.

You do not need to change anything for this pull request, but we will put all the names at the beginning of the script when we will work on these scripts that you added. Please let me know if you have any thoughts :)

@keiyamamo keiyamamo merged commit 29657b5 into KVSlab:master Sep 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants