-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple test cylinder #52
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 70.98% 71.72% +0.74%
==========================================
Files 10 10
Lines 1151 1192 +41
==========================================
+ Hits 817 855 +38
- Misses 334 337 +3 |
Hi @dbruneau-mie |
@dbruneau-mie I talked with @jorgensd about the authorship for each functions and we concluded that listing all the authors' name at the top of script is better than listing author name for each functions. If we include author name as doc-string in each functions, user will be exposed to the author name when using You do not need to change anything for this pull request, but we will put all the names at the beginning of the script when we will work on these scripts that you added. Please let me know if you have any thoughts :) |
Simple test cylinder added to repo.