chore: adjust from feedback

Kajabi · Aug 23, 2022 · 62c7bf1 · 62c7bf1
1 parent 14c6be0
commit 62c7bf1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/docs/lib/sage_rails/app/views/sage_components/_sage_list.html.erb b/docs/lib/sage_rails/app/views/sage_components/_sage_list.html.erb
@@ -1,8 +1,6 @@
 <%
 tag = component.sortable ? "ol" : "ul"
-if component.tag.present?
-  tag = component.tag
-end
+tag = component.tag || tag
 drag_handle_type = component.drag_handle_type.present? ? component.drag_handle_type : "default"
 %>
 <<%= tag %>

diff --git a/packages/sage-react/lib/List/List.jsx b/packages/sage-react/lib/List/List.jsx
@@ -45,9 +45,7 @@ export const List = ({
   };
 
   let Tag = sortable ? 'ol' : 'ul';
-  if (tag) {
-    Tag = tag;
-  }
+  Tag = tag || Tag;
 
   return sortable ? (
     <ReactSortable
@@ -76,7 +74,7 @@ export const List = ({
         }
       }}
       setList={setList}
-      tag={tag}
+      tag={Tag}
     >
       {renderItems()}
     </ReactSortable>
@@ -94,11 +92,11 @@ List.defaultProps = {
   children: null,
   className: null,
   items: [],
-  itemRenderer: () => null,
+  itemRenderer: () => {},
   dragHandleType: List.DRAG_HANDLE_TYPES.DEFAULT,
-  onEnd: () => null,
-  onStart: () => null,
-  setList: () => [],
+  onEnd: () => {},
+  onStart: () => {},
+  setList: () => {},
   sortable: false,
   tag: null,
 };