Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-420] Correct icons in Alert React component #1745

Merged
merged 2 commits into from
Jun 8, 2023
Merged

[DSS-420] Correct icons in Alert React component #1745

merged 2 commits into from
Jun 8, 2023

Conversation

teenwolfblitzer
Copy link
Member

@teenwolfblitzer teenwolfblitzer commented Jun 7, 2023 •
edited
Loading

Description

DSS-420

Icons displayed for the Alert warning/approaching and danger/exceeded React component are reversed from the designs in Figma.

Screenshots

Before After
Warning warning-before warning-after
Danger danger-before danger-after

Testing in sage-lib

  1. Navigate to the Alert component in Storybook
  2. Select the "Warning" and "Danger" variants from the color dropdown
  3. Confirm that the icons match the Figma spec and Rails component

Testing in kajabi-products

  1. (HIGH) Alert - icons updated for "Warning" and "Danger" React component. Style-only; no anticipated change in functionality
    • Payments Integrations -> Kajabi Payments 2FA alert
    • Custom email domain (CEDS) upgrade alert

@teenwolfblitzer teenwolfblitzer self-assigned this Jun 7, 2023
@teenwolfblitzer teenwolfblitzer marked this pull request as ready for review June 7, 2023 20:41
@teenwolfblitzer teenwolfblitzer requested a review from a team June 7, 2023 20:41
pixelflips
pixelflips approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns here, nice catch! 🚀

@pixelflips pixelflips requested a review from a team June 7, 2023 21:02
@ju-Skinner ju-Skinner requested a review from a team June 8, 2023 20:55
@teenwolfblitzer teenwolfblitzer merged commit 2dcb90b into develop Jun 8, 2023
@teenwolfblitzer teenwolfblitzer deleted the DSS-420_react_alert_icon_mismatch branch June 8, 2023 23:13
@teenwolfblitzer teenwolfblitzer mentioned this pull request Jun 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@teenwolfblitzer teenwolfblitzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teenwolfblitzer @pixelflips @ju-Skinner