Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-430] add typing variant #1757

Merged
merged 2 commits into from
Jun 27, 2023
Merged

[DSS-430] add typing variant #1757

merged 2 commits into from
Jun 27, 2023

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Jun 26, 2023 •
edited
Loading

Description

  • add the typing variant to the Loader component

Screenshots

typingIndicator

Testing in sage-lib

Visit the Loader React page and verify the typing variant

Testing in kajabi-products

  1. (LOW) Add typing variant to Loader react component. Does not exist in the app.

Related

Closes DSS-430

@QuintonJason QuintonJason marked this pull request as ready for review June 26, 2023 20:56
@QuintonJason QuintonJason self-assigned this Jun 26, 2023
@QuintonJason QuintonJason requested review from AndrwM and a team June 26, 2023 20:56
pixelflips
pixelflips approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great, nice job! LGTM! 👍🏼

If possible it would be great to have the rails equivalent as a followup if this one is needed quickly, but not a show-stopper.

@pixelflips
Copy link
Member

We should get the design team to account for this new variant in the new system figma files as well so we don't forget about it.

@pixelflips pixelflips requested a review from a team June 26, 2023 21:09
AndrwM
AndrwM approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@AndrwM AndrwM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great tysm

@QuintonJason
Copy link
Contributor Author

Looks and works great, nice job! LGTM! 👍🏼

If possible it would be great to have the rails equivalent as a followup if this one is needed quickly, but not a show-stopper.

Great callout! Added a request in the Conversational AI design spec for that section

@QuintonJason QuintonJason merged commit 3b6a91a into develop Jun 27, 2023
@QuintonJason QuintonJason deleted the DSS-430/loader-typing-variant branch June 27, 2023 17:51
@ju-Skinner ju-Skinner mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflips pixelflips pixelflips approved these changes

@AndrwM AndrwM AndrwM approved these changes

Assignees

@QuintonJason QuintonJason

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuintonJason @pixelflips @AndrwM