Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal fade out update #1759

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Modal fade out update #1759

merged 5 commits into from
Jul 5, 2023

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Jun 30, 2023 •
edited
Loading

Description

  • Add fadeout transition to Modal
  • Add fadeout transiton to drawer

Screenshots

Before After
modalFadeOutBefore modalFadeOutAfter

Testing in sage-lib

Visit the Modal and select the wired variant. Verify that closing the modal fades out
Visit the Drawer and select the wired variant. Verify that closing the modal fades out

Testing in kajabi-products

  1. (LOW) Adds a fadeout that must be opted into. No affect in kp

Related

@QuintonJason QuintonJason marked this pull request as ready for review June 30, 2023 15:22
@QuintonJason QuintonJason requested a review from a team June 30, 2023 15:22
ju-Skinner
ju-Skinner requested changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: This is NON-Blocking. I hit requested changes prematurely.

I would like to see more documentation on how to use and set up. You can look to add a .story.mdx file that can provide additional documentation needs. See packages/sage-react/lib/DataCard/DataCardGroupNotes.story.mdx for an example.

@ju-Skinner ju-Skinner requested a review from a team June 30, 2023 15:29
pixelflips
pixelflips approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼 I agree with the documentation update, but not a showstopper atm. Nice work!

@QuintonJason QuintonJason mentioned this pull request Jul 5, 2023
Merged
@QuintonJason QuintonJason merged commit d1652b1 into develop Jul 5, 2023
@QuintonJason QuintonJason deleted the modal-fade-out-update branch July 5, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuintonJason @pixelflips @ju-Skinner