New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSS-438] Upload Card - Selected File Error State #1765

Merged

anechol merged 1 commit into develop from feature/upload-error-state

Jul 19, 2023

Contributor

anechol commented Jul 19, 2023 •

edited by jira bot

Loading

Description

Adds an error state for selected files.

Screenshots

Before	After

Testing in `sage-lib`

Rails

Navigate to Upload Card
Check that adding an error to the selected file state properly adds error styling

React

Navigate to Upload Card
Check that adding an error to the selected file state properly adds error styling

Testing in `kajabi-products`

(LOW) Adds an error state for selected files.

Related


          style(upload card): adds error styling to selected file state

08c30c6

anechol added the improvement label

anechol requested a review from a team

July 19, 2023 19:00

anechol self-assigned this

pixelflips approved these changes

View reviewed changes

Member

pixelflips left a comment

👍🏼 - LGTM! Thanks for including the documentation updates as well!

pixelflips requested a review from a team

July 19, 2023 19:28

ju-Skinner approved these changes

View reviewed changes

Collaborator

ju-Skinner left a comment

LGTM

ju-Skinner requested a review from a team

July 19, 2023 19:45

anechol merged commit ad3c2bf into develop

anechol mentioned this pull request

Next Version Bump #1767

Merged

ju-Skinner deleted the feature/upload-error-state branch

October 24, 2023 15:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels