From 95bb9c371af1ef075d6fa2a450049242ccc6d23d Mon Sep 17 00:00:00 2001 From: Phillip Lovelace Date: Mon, 24 Jun 2024 11:51:37 -0700 Subject: [PATCH 1/2] fix(label): adds missing icon and corrects class type --- packages/sage-react/lib/Label/Label.jsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/sage-react/lib/Label/Label.jsx b/packages/sage-react/lib/Label/Label.jsx index 81244a9fd7..ba223cb240 100644 --- a/packages/sage-react/lib/Label/Label.jsx +++ b/packages/sage-react/lib/Label/Label.jsx @@ -1,7 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import classnames from 'classnames'; -import { SageTokens } from '../configs'; +import { SageTokens, SageClassnames } from '../configs'; import { LABEL_COLORS, LABEL_STYLES, @@ -61,13 +61,19 @@ export const Label = React.forwardRef(({ type={interactiveType ? 'button' : null} {...rest} > + {icon && ( + + )} {value} {interactiveType === LABEL_INTERACTIVE_TYPES.SECONDARY_BUTTON && secondaryButton} {(interactiveType === LABEL_INTERACTIVE_TYPES.DROPDOWN) && ( - + )} ); From a572f81bfb864d9ad0788ffa4744c744b88bb831 Mon Sep 17 00:00:00 2001 From: Phillip Lovelace Date: Mon, 24 Jun 2024 12:00:00 -0700 Subject: [PATCH 2/2] fix: hello linter my old friend --- packages/sage-react/lib/Label/Label.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sage-react/lib/Label/Label.jsx b/packages/sage-react/lib/Label/Label.jsx index ba223cb240..2c75b68f94 100644 --- a/packages/sage-react/lib/Label/Label.jsx +++ b/packages/sage-react/lib/Label/Label.jsx @@ -64,7 +64,7 @@ export const Label = React.forwardRef(({ {icon && ( )}