From 30253dabcd78fe8abd6f114f96ecd042d9a6478b Mon Sep 17 00:00:00 2001 From: Julian Skinner Date: Thu, 5 Sep 2024 10:35:40 -0500 Subject: [PATCH 1/3] feat(loader-rails): change the loader animation and fill color --- .../sage_components/_sage_loader.html.erb | 21 ++++++++-- .../lib/stylesheets/components/_loader.scss | 38 +++++++++---------- 2 files changed, 35 insertions(+), 24 deletions(-) diff --git a/docs/lib/sage_rails/app/views/sage_components/_sage_loader.html.erb b/docs/lib/sage_rails/app/views/sage_components/_sage_loader.html.erb index 91cd1973cc..111436cb76 100644 --- a/docs/lib/sage_rails/app/views/sage_components/_sage_loader.html.erb +++ b/docs/lib/sage_rails/app/views/sage_components/_sage_loader.html.erb @@ -1,5 +1,6 @@ <% component_description = component.type === "success" ? "Success" : "Loading..." + stroke_color = SageTokens::COLOR_PALETTE[:MERCURY_40] %>
-> +> <%# Spinner SVG %> <% if component.type === "spinner" %> - - + + + + + + + + + + + + + + + + <% end %> diff --git a/packages/sage-assets/lib/stylesheets/components/_loader.scss b/packages/sage-assets/lib/stylesheets/components/_loader.scss index 014e30b0ca..b97c1f79e1 100644 --- a/packages/sage-assets/lib/stylesheets/components/_loader.scss +++ b/packages/sage-assets/lib/stylesheets/components/_loader.scss @@ -11,7 +11,6 @@ $-loader-bar-speed-delay: 0.5s; $-loader-bar-width: rem(300px); $-loader-spinner-size: rem(48px); $-loader-spinner-speed: 2s; -$-loader-spinner-path-speed: 1.5s; $-loader-typing-size: rem(6px); $-loader-lower-opacity: 0.4; @@ -84,7 +83,7 @@ $-loader-lower-opacity: 0.4; .sage-loader__spinner { width: sage-spacing(xl); height: sage-spacing(xl); - animation: rotate $-loader-spinner-speed linear infinite; + animation: loader-rotate $-loader-spinner-speed linear infinite; } .sage-loader__spinner--loading-button { @@ -94,11 +93,20 @@ $-loader-lower-opacity: 0.4; } .sage-loader__spinner-path { - stroke-dasharray: 150, 200; - stroke-dashoffset: -10; + stroke-width: 8px; +} + +.sage-loader__spinner-secondHalf { + stroke: url("#sage-loader__spinner-secondHalf"); +} + +.sage-loader__spinner-firstHalf { + stroke: url("#sage-loader__spinner-firstHalf"); +} + +.sage-loader__spinner-highlight { + stroke: currentColor; stroke-linecap: round; - stroke: sage-color(primary, 300); - animation: dash $-loader-spinner-path-speed ease-in-out infinite; } .sage-loader__spinner-path--loading-button { @@ -146,24 +154,12 @@ $-loader-lower-opacity: 0.4; } } -@keyframes rotate { - 100% { - transform: rotate(360deg); - } -} - -@keyframes dash { +@keyframes loader-rotate { 0% { - stroke-dasharray: 1, 200; - stroke-dashoffset: 0; - } - 50% { - stroke-dasharray: 89, 200; - stroke-dashoffset: -35; + transform: rotate(0deg); } 100% { - stroke-dasharray: 89, 200; - stroke-dashoffset: -124; + transform: rotate(360deg); } } From df2cca2ac67798f61d05058e295c5d095e9d1217 Mon Sep 17 00:00:00 2001 From: Julian Skinner Date: Thu, 5 Sep 2024 10:59:36 -0500 Subject: [PATCH 2/3] feat(loader-react): change the loader animation and fill color --- packages/sage-react/lib/Loader/Loader.jsx | 58 +++++++++++++++-------- 1 file changed, 38 insertions(+), 20 deletions(-) diff --git a/packages/sage-react/lib/Loader/Loader.jsx b/packages/sage-react/lib/Loader/Loader.jsx index 115193c292..27f6a89d50 100644 --- a/packages/sage-react/lib/Loader/Loader.jsx +++ b/packages/sage-react/lib/Loader/Loader.jsx @@ -2,6 +2,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import classnames from 'classnames'; import { LOADER_TYPES } from './configs'; +import { SageTokens } from '../configs'; export const Loader = ({ fillSpace, @@ -33,34 +34,51 @@ export const Loader = ({ {(type === LOADER_TYPES.SPINNER_IN_BUTTON) && ( )} {(type === LOADER_TYPES.SPINNER) && ( )} {(type === LOADER_TYPES.SUCCESS) && ( From 078f473e01b95e8b8c2cdd158e18e0438a86ee1d Mon Sep 17 00:00:00 2001 From: Julian Skinner Date: Thu, 5 Sep 2024 12:59:48 -0500 Subject: [PATCH 3/3] style(loader): change timing to 1.5s per convo with design team --- packages/sage-assets/lib/stylesheets/components/_loader.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sage-assets/lib/stylesheets/components/_loader.scss b/packages/sage-assets/lib/stylesheets/components/_loader.scss index b97c1f79e1..1ae92a2902 100644 --- a/packages/sage-assets/lib/stylesheets/components/_loader.scss +++ b/packages/sage-assets/lib/stylesheets/components/_loader.scss @@ -10,7 +10,7 @@ $-loader-bar-speed: 1.2s; $-loader-bar-speed-delay: 0.5s; $-loader-bar-width: rem(300px); $-loader-spinner-size: rem(48px); -$-loader-spinner-speed: 2s; +$-loader-spinner-speed: 1.5s; $-loader-typing-size: rem(6px); $-loader-lower-opacity: 0.4;