Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 🚧 add starknet_version and eth_l1_gas_price #101

Merged
merged 3 commits into from
Jan 16, 2024
Merged

refactor: 🚧 add starknet_version and eth_l1_gas_price #101

merged 3 commits into from
Jan 16, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Jan 16, 2024

  • add starknet_version and eth_l1_gas_price in DB
  • change type of starknet_version from u8 to Felt252Wrapper

Pull Request type

  • Feature

What is the current behavior?

Resolves: #25 #26

What is the new behavior?

  • The block headers contain the starknet _version and eth_l1_gas_fee fields

Does this introduce a breaking change?

No

Other information

add starknet_version and eth_l1_gas_price in DB, change type of starknet_version from u8 to Felt252Wrapper

#25 , #26
@antiyro
Copy link
Member

antiyro commented Jan 16, 2024

Could you add changelogs and run npx prettier -w ., npx @taplo/cli fmt --config ./taplo/taplo.toml and cargo fmt just to unlock most of the checks

@antiyro antiyro merged commit 8f746a9 into KasarLabs:main Jan 16, 2024
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat/starknet_getBlockWithTxHashes
2 participants