Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error and help messages for --rex-authpath #296

Closed
evgeni opened this issue Feb 21, 2019 · 0 comments
Closed

improve error and help messages for --rex-authpath #296

evgeni opened this issue Feb 21, 2019 · 0 comments

Comments

@evgeni
Copy link
Member

evgeni commented Feb 21, 2019 

[root@rhel7 ~]# ./bootstrap.py -l admin -s  sat6-5-rhel7-6.example.com -o 'Default Organization' -L 'Default Location' -g  TestHG -a test_ak --rex --rex-authpath /tmp -v --force --skip-puppet

[ERROR], [2019-02-15 06:28:33], EXITING: [Foreman's SSH key not installed. File where authorized_keys must be located is not found: /tmp] failed to execute properly.

The user needs to pass a file path, not a folder, we should tell them that.
evgeni added a commit to evgeni/katello-client-bootstrap that referenced this issue Feb 21, 2019
@evgeni
improve error message and allow non-existing files for --rex-authpath
cc30bcf 
Users might pass a folder, but we really expect a file here, so let the
error message say this.

Also, the code can actually handle a non-existing file just fine, as it
will create it if it does not exist, so let's just error if the path
given exists but is not a file.

Fixes: Katello#296
@evgeni evgeni mentioned this issue Feb 21, 2019
Merged
evgeni added a commit that referenced this issue Feb 26, 2019
@evgeni
improve error message and allow non-existing files for --rex-authpath (…
b55dd58 
…#299)

Users might pass a folder, but we really expect a file here, so let the
error message say this.

Also, the code can actually handle a non-existing file just fine, as it
will create it if it does not exist, so let's just error if the path
given exists but is not a file.

Fixes: #296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evgeni