add option to ignore registration failures #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Aug 23, 2018
| @@ -348,8 +348,12 @@ def migrate_systems(org_name, activationkey): | |||
| else: | |||
| options.rhsmargs += " --keep" | |||
| exec_failok("/usr/sbin/subscription-manager config --server.server_timeout=%s" % options.timeout) | |||
| exec_failexit("/usr/sbin/rhn-migrate-classic-to-rhsm --org %s --activation-key '%s' %s" % (org_label, activationkey, options.rhsmargs)) | |||
| exec_failexit("subscription-manager config --rhsm.baseurl=https://%s/pulp/repos" % options.foreman_fqdn) | |||
| if options.ignore_registration_failures: | |||
There was a problem hiding this comment.
reading these branches, I wonder how often we will forget to update params in one of them.
how about we mangle exec_failok and exec_failexit into one function exec(command, failok=False) and make the other two sensible aliases to it? then we can just pass ignore_r_f as the failok param.
There was a problem hiding this comment.
ack, but I'd rather handle a refactoring of the exec* functions as a different PR. (because I am bound to mess it up :) )
evgeni
approved these changes
Sep 17, 2018
evgeni
added a commit
to evgeni/katello-client-bootstrap
that referenced
this pull request
Jan 24, 2019
changelog: * Python 3 support * Capability to preserve proxy settings when reconfiguring/migrating the client (Katello#283) * EL5 subscription manager compatibility fixes (Katello#284) * Only yum clean metadata and dbcache, not RPMs (Katello#280) * Allow defining where to get ssh keys and where to store them (Katello#281) * Make the FIPS check more robust (Katello#279) * Support yum and dnf Python bindings (Katello#271) * Option to ignore registration failures (Katello#261) * Force lowercase FQDN writing puppet configuration (Katello#255) * Improve the error message when a search fails (Katello#257)
Merged
evgeni
added a commit
that referenced
this pull request
Jan 25, 2019
changelog: * Python 3 support * Capability to preserve proxy settings when reconfiguring/migrating the client (#283) * EL5 subscription manager compatibility fixes (#284) * Only yum clean metadata and dbcache, not RPMs (#280) * Allow defining where to get ssh keys and where to store them (#281) * Make the FIPS check more robust (#279) * Support yum and dnf Python bindings (#271) * Option to ignore registration failures (#261) * Force lowercase FQDN writing puppet configuration (#255) * Improve the error message when a search fails (#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260