diff --git a/example/README.md b/example/README.md index 46dd08ef..3c3d8180 100644 --- a/example/README.md +++ b/example/README.md @@ -13,7 +13,7 @@ csilvers is Craig Silverstein ## Running genqlient -It's already checked in to github, but to regenerate `generated.go`: +It's already checked in to GitHub, but to regenerate `generated.go`: ```sh go generate ./... ``` diff --git a/example/cmd/example/main.go b/example/cmd/example/main.go index 823bb68e..62b8a03b 100644 --- a/example/cmd/example/main.go +++ b/example/cmd/example/main.go @@ -1,7 +1,7 @@ package main import ( - example "github.com/Khan/genqlient/example" + "github.com/Khan/genqlient/example" ) func main() { diff --git a/generate/convert.go b/generate/convert.go index 3fb2804f..35287468 100644 --- a/generate/convert.go +++ b/generate/convert.go @@ -90,7 +90,7 @@ func (g *generator) convertInputType( options, queryOptions *genqlientDirective, ) (goType, error) { // note prefix is ignored here (see generator.typeName), as is selectionSet - // (for input types we use the whole thing)). + // (for input types we use the whole thing). return g.convertType(nil, typ, nil, options, queryOptions) } @@ -463,7 +463,7 @@ func (g *generator) convertInlineFragment( containingTypedef *ast.Definition, queryOptions *genqlientDirective, ) ([]*goStructField, error) { - // You might think fragmentTypedef would be fragment.ObjectDefinition, but + // You might think fragmentTypedef would be a fragment.ObjectDefinition, but // actually that's the type into which the fragment is spread. fragmentTypedef := g.schema.Types[fragment.TypeCondition] if !fragmentMatches(containingTypedef, fragmentTypedef) { diff --git a/generate/description.go b/generate/description.go index 0c37301a..13581771 100644 --- a/generate/description.go +++ b/generate/description.go @@ -18,7 +18,7 @@ type descriptionInfo struct { CommentOverride string // name of the corresponding GraphQL type GraphQLName string - // GraphQL description of the type .GraphQLName, if any + // GraphQL schema's description of the type .GraphQLName, if any GraphQLDescription string // name of the corresponding GraphQL fragment (on .GraphQLName), if any FragmentName string diff --git a/generate/types.go b/generate/types.go index 979fc340..d62ee1d2 100644 --- a/generate/types.go +++ b/generate/types.go @@ -245,7 +245,7 @@ func (typ *goInterfaceType) WriteDefinition(w io.Writer, g *generator) error { "Get%s is a part of, and documented with, the interface %s.", sharedField.GoName, typ.GoName) writeDescription(w, description) - // In principle we should find the corresponding field of the + // In principle, we should find the corresponding field of the // implementation and use its name in `v.`. In practice, // they're always the same. fmt.Fprintf(w, "func (v *%s) Get%s() %s { return v.%s }\n", diff --git a/graphql/client.go b/graphql/client.go index a01c34f5..1883db46 100644 --- a/graphql/client.go +++ b/graphql/client.go @@ -11,7 +11,7 @@ import ( "github.com/vektah/gqlparser/v2/gqlerror" ) -// Client is the interface that the generate code calls into to actually make +// Client is the interface that the generated code calls into to actually make // requests. // // Unstable: This interface is likely to change before v1.0, see #19. diff --git a/graphql/util.go b/graphql/util.go index b5b4564a..9a399c35 100644 --- a/graphql/util.go +++ b/graphql/util.go @@ -6,7 +6,7 @@ package graphql // NoUnmarshalJSON is intended for the use of genqlient's generated code only. // // It is used to prevent a struct type from inheriting its embed's -// UnmarshalJSON method: given a type +// UnmarshalJSON method, so if we construct a type: // type T struct { E; NoUnmarshalJSON } // where E has an UnmarshalJSON method, T will not inherit it, per the Go // selector rules: https://golang.org/ref/spec#Selectors. diff --git a/internal/integration/integration_test.go b/internal/integration/integration_test.go index 45293720..bee2ef7c 100644 --- a/internal/integration/integration_test.go +++ b/internal/integration/integration_test.go @@ -223,7 +223,7 @@ func TestInterfaceListPointerField(t *testing.T) { assert.Equal(t, "Yours Truly", (*resp.Beings[0]).GetName()) user, ok := (*resp.Beings[0]).(*queryWithInterfaceListPointerFieldBeingsUser) - require.Truef(t, ok, "got %T, not User", (*resp.Beings[0])) + require.Truef(t, ok, "got %T, not User", *resp.Beings[0]) assert.Equal(t, "1", user.Id) assert.Equal(t, "Yours Truly", user.Name)