Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Deep Mirror for author id #171

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

lyh-dm
Copy link
Contributor

@lyh-dm lyh-dm commented May 27, 2024

Register Deep Mirror for author id

@CLAassistant
Copy link

CLAassistant commented May 27, 2024

CLA assistant check
All committers have signed the CLA.

@rpavlik
Copy link
Contributor

rpavlik commented May 28, 2024

Are you making a runtime, or an API layer, out of curiosity?

@lyh-dm
Copy link
Contributor Author

lyh-dm commented May 29, 2024

@rpavlik I want to create some extensions for our device.

@lyh-dm
Copy link
Contributor Author

lyh-dm commented May 31, 2024

Hi @rpavlik , could you please help to review this PR? Thanks.
Oh sorry, seems I misunderstand your last question. We want to implement the extension functions in a new API layer. If I understand correctly, we need such an author ID to register these new functions and new data struct to the OpenXR-SDK.

@rpavlik
Copy link
Contributor

rpavlik commented May 31, 2024

Yep, this is right for creating new extensions. Most of the time extensions are implemented in the runtime itself, but some can be implemented in extensions if that works better for the use case.

Add change log for author id
@rpavlik rpavlik changed the base branch from main to staging May 31, 2024 17:19
@rpavlik rpavlik self-requested a review May 31, 2024 17:19
@rpavlik rpavlik merged commit 0d99e03 into KhronosGroup:staging May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants