Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear debug information for kill and replacement #3459

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Clear debug information for kill and replacement #3459

merged 4 commits into from
Jun 25, 2020

Commits on Jun 23, 2020

  1. Clear debug information for kill and replacement 

    For many spirv-opt passes such as simplify-instructions pass, we have to
correctly clear the OpenCL.DebugInfo.100 debug information for
KillInst() and ReplaceAllUses(). If we keep some debug information that
disappeared because of KillInst() and ReplaceAllUses(), adding new
DebugValue instructions will generate incorrect information. This CL
update DebugInfoManager and IRContext to correctly clear debug
information.
    @jaebaek
    jaebaek committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    45e812e View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Updated based on code review

    @jaebaek
    jaebaek committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    3c3ad09 View commit details
    Browse the repository at this point in the history

  2. Fix unit test failure

    @jaebaek
    jaebaek committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    91e546c View commit details
    Browse the repository at this point in the history

  3. Restore unit test and use DAG for order issue

    @jaebaek
    jaebaek committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    ff7e23d View commit details
    Browse the repository at this point in the history