Circle #3860

Irev-Dev · 2024-09-10T21:54:29Z

Remaining tasks

Tests

draft circle should look right (snapshot)
Can create a new sketch and put a circle on it.
Can edit an existing circle changing its center and radius
test for the overlay
point and click extrude should work with circle sketches.

qa-wolf · 2024-09-10T21:54:31Z

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

vercel · 2024-09-10T21:54:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Sep 20, 2024 10:24pm

src/wasm-lib/kcl/src/std/shapes.rs

jtran · 2024-09-13T01:13:11Z

Doc comments that use circle() need to get updated. Maybe shell.rs was added in your last rebase?

modeling-app/src/wasm-lib/kcl/src/std/shell.rs

Line 118 in db6036f

/// |> circle([-size / 2, -size / 2], 25, %)

jtran · 2024-09-13T01:21:58Z

The error message I see a lot of is Expected a Path::ToPoint variant. This is one example that's failing.

modeling-app/src/wasm-lib/kcl/src/std/convert.rs

Lines 52 to 58 in db6036f

    
           /// const sketch001 = startSketchOn('XZ') 
        
           ///   |> circle({ center: [0, 0], radius: 2 }, %) 
        
           /// const extrude001 = extrude(5, sketch001) 
        
           /// 
        
           /// const pattern01 = patternTransform(int(ceil(5 / 2)), (id) => { 
        
           ///   return { translate: [4 * id, 0, 0] } 
        
           /// }, extrude001)

When extruding a circle, do_post_extrude() seems to be expecting a Path::ToPoint to extract an edge ID, but it's not finding it with the circle. Not sure what needs to change here.

modeling-app/src/wasm-lib/kcl/src/std/extrude.rs

Line 147 in db6036f

if let Path::ToPoint { base } = segment {

Irev-Dev · 2024-09-13T11:30:16Z

That is super helpful @jtran thank you.

I think it's because https://github.com/KittyCAD/modeling-app/pull/3860/files#diff-b007215ec7d21c68d6a4487af28c6a25fa8cf5fc95ae008e07e5680261cab1f1L73-L80

circle used to call inner_arc which used ToPoint, but now doesn't. I'm not 100% sure what I need to update yet but at least makes sense why it's unhappy.

codecov · 2024-09-16T08:43:17Z

Codecov Report

Attention: Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.16%. Comparing base (3e79b90) to head (414b11d).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
src/wasm-lib/kcl/src/executor.rs	50.00%	3 Missing ⚠️
src/wasm-lib/kcl/src/std/extrude.rs	75.00%	1 Missing ⚠️
src/wasm-lib/kcl/src/std/shapes.rs	98.03%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3860      +/-   ##
==========================================
+ Coverage   87.15%   87.16%   +0.01%     
==========================================
  Files          69       69              
  Lines       25121    25176      +55     
==========================================
+ Hits        21894    21945      +51     
- Misses       3227     3231       +4

Flag	Coverage Δ
wasm-lib	`87.16% <94.84%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-19T23:59:45Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2024-09-20T00:00:02Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

src/clientSideScene/sceneEntities.ts

src/wasm-lib/kcl/src/std/shapes.rs

jtran

I commented on a couple minor things. But if getting CI to pass was tough, I'd say merge it. Fast follow up PR would be nice though.

adamchalmers · 2024-09-20T16:03:55Z

src/wasm-lib/kcl/src/executor.rs

@@ -1438,6 +1438,19 @@ pub enum Path {
        /// arc's direction
        ccw: bool,
    },
+    /// a complete arc
+    Circle {


Sorry if this is obvious, but, why is Circle a kind of path segment? How can you add more path segments before or after a circle? It doesn't make sense to me to have a circle as part of a sequence of paths. Shouldn't it just be a shortcut for creating a path with 1 segment, a TangentialArc from 0 to 360 degrees?

inner_arc is very messed up because some of the arc structs are messed up, it returns a path segment using ToPoint, I didn't want to change how the arc segments work in case that's a breaking change. I know if the other arcs are not working correctly I'm just leaving the dirt under the rug and not doing anything about it, but I plan on taking a second pass where I add arcs to the client side scene in which case the arcs structs in rust will probably need some attention too, in which case I'll likely remove this struct again.

I was talking to @jtran about it too, I'll likely remove all but one of the arcs, I don't think there's a need for tangencialArc and arc for example, I think we got confused between the API for users and the functions available to them vs the data we store under-the-hood, I think we only need a struct for each curve type, so straight lines and arcs at this point, but later splines etc etc.

Do you think it's okay to put this circle struct in here short term?

Yeah in the interests of getting this merged I'm happy to include it, but it doesn't really make sense. Let's consolidate this when you fix up the arcs though. Could you just make an issue for it, and leave the issue in the source code here as a comment? So we don't lose track of it.

Sounds good 414b11d

src/wasm-lib/kcl/src/std/shapes.rs

github-actions · 2024-09-20T21:48:33Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Irev-Dev · 2024-09-20T21:51:00Z

src/clientSideScene/ClientSideSceneComp.tsx

-    canvas.addEventListener('mouseup', sceneInfra.onMouseUp, false)
+    canvas.addEventListener(
+      'mouseup',
+      toSync(sceneInfra.onMouseUp, reportRejection),


@jtran re #3860 (comment)

I think this is the appropriate way to make us toSync right?
I had to change the return types of these callbacks to be promisy/async, but these went listeners need to be synchronous.

Yes, awesome! I didn't expect you to fix all the old ignores too, but this is great. Ideally, we'd get rid of them all eventually.

github-actions · 2024-09-20T21:52:38Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

github-actions · 2024-09-20T22:00:10Z

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Irev-Dev mentioned this pull request Sep 10, 2024

segment refactor + Circle [WIP] #3695

Closed

17 tasks

vercel bot deployed to Preview September 10, 2024 22:04 View deployment

Irev-Dev force-pushed the kurt-circle-rebase branch from 4f5731c to 5b31a6b Compare September 11, 2024 12:09

vercel bot deployed to Preview September 11, 2024 12:21 View deployment

Irev-Dev changed the base branch from kurt-refactor-client-side-scene to main September 11, 2024 19:56

vercel bot deployed to Preview September 11, 2024 20:10 View deployment

Irev-Dev force-pushed the kurt-circle-rebase branch from 39095be to 2a233d8 Compare September 12, 2024 00:41

vercel bot deployed to Preview September 12, 2024 01:00 View deployment

vercel bot deployed to Preview September 12, 2024 01:36 View deployment

jtran reviewed Sep 13, 2024

View reviewed changes

src/wasm-lib/kcl/src/std/shapes.rs Outdated Show resolved Hide resolved

Irev-Dev force-pushed the kurt-circle-rebase branch from db6036f to 94952a1 Compare September 13, 2024 11:09

vercel bot deployed to Preview September 13, 2024 11:21 View deployment

circle

2a468c9

Irev-Dev force-pushed the kurt-circle-rebase branch from 94952a1 to 2a468c9 Compare September 13, 2024 11:25

Irev-Dev added 2 commits September 13, 2024 21:30

fix another example

fcf3761

fix bad comment

d5f3e02

vercel bot deployed to Preview September 13, 2024 11:47 View deployment

Irev-Dev added 3 commits September 16, 2024 16:48

Merge remote-tracking branch 'origin' into kurt-circle-rebase

f856000

toPoint fix

b3c02ab

cargo fmt

d4bbd3f

vercel bot deployed to Preview September 16, 2024 07:15 View deployment

Irev-Dev added 2 commits September 16, 2024 18:14

resolve most of the tests

8792704

fix last test

b28c99e

vercel bot deployed to Preview September 16, 2024 08:31 View deployment

Irev-Dev added 2 commits September 20, 2024 09:59

skip un reproducable windows test failure

c4f5965

Merge branch 'main' into kurt-circle-rebase

e281b22

vercel bot deployed to Preview September 20, 2024 00:22 View deployment

jtran reviewed Sep 20, 2024

View reviewed changes

src/clientSideScene/sceneEntities.ts Outdated Show resolved Hide resolved

jtran reviewed Sep 20, 2024

View reviewed changes

src/clientSideScene/sceneEntities.ts Outdated Show resolved Hide resolved

jtran reviewed Sep 20, 2024

View reviewed changes

src/wasm-lib/kcl/src/std/shapes.rs Outdated Show resolved Hide resolved

jtran approved these changes Sep 20, 2024

View reviewed changes

adamchalmers reviewed Sep 20, 2024

View reviewed changes

rust review

438928f

Irev-Dev commented Sep 20, 2024

View reviewed changes

Merge remote-tracking branch 'origin' into kurt-circle-rebase

ea9b36d

Irev-Dev removed request for lf94 and nadr0 September 20, 2024 21:54

adamchalmers approved these changes Sep 20, 2024

View reviewed changes

Irev-Dev mentioned this pull request Sep 20, 2024

consolidate segment enums #3940

Open

leave issue todo comment

414b11d

vercel bot deployed to Preview September 20, 2024 22:24 View deployment

Irev-Dev mentioned this pull request Sep 23, 2024

Sketch on chamfer UI #3918

Merged

adamchalmers merged commit f1b0e40 into main Sep 23, 2024
31 checks passed

adamchalmers deleted the kurt-circle-rebase branch September 23, 2024 12:42

Irev-Dev mentioned this pull request Sep 23, 2024

Cut release v0.25.4 #3952

Merged

r-barton mentioned this pull request Sep 23, 2024

Update to new circle KCL KittyCAD/kcl-samples#92

Closed

This was referenced Sep 26, 2024

Make releases with breaking changes LOUDER #3996

Closed

Changelog view or Breaking Change Message #3984

Closed

Irev-Dev mentioned this pull request Oct 1, 2024

Add circle from center tool #1501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Circle #3860

Circle #3860

Irev-Dev commented Sep 10, 2024 •

edited

Loading

qa-wolf bot commented Sep 10, 2024

vercel bot commented Sep 10, 2024 •

edited

Loading

jtran commented Sep 13, 2024

jtran commented Sep 13, 2024 •

edited

Loading

Irev-Dev commented Sep 13, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 20, 2024

jtran left a comment

adamchalmers Sep 20, 2024

Irev-Dev Sep 20, 2024

adamchalmers Sep 20, 2024

Irev-Dev Sep 20, 2024

github-actions bot commented Sep 20, 2024

Irev-Dev Sep 20, 2024

jtran Sep 23, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

Circle #3860

Circle #3860

Conversation

Irev-Dev commented Sep 10, 2024 • edited Loading

qa-wolf bot commented Sep 10, 2024

vercel bot commented Sep 10, 2024 • edited Loading

jtran commented Sep 13, 2024

jtran commented Sep 13, 2024 • edited Loading

Irev-Dev commented Sep 13, 2024 • edited Loading

codecov bot commented Sep 16, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 20, 2024

jtran left a comment

Choose a reason for hiding this comment

adamchalmers Sep 20, 2024

Choose a reason for hiding this comment

Irev-Dev Sep 20, 2024

Choose a reason for hiding this comment

adamchalmers Sep 20, 2024

Choose a reason for hiding this comment

Irev-Dev Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024

Irev-Dev Sep 20, 2024

Choose a reason for hiding this comment

jtran Sep 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

Irev-Dev commented Sep 10, 2024 •

edited

Loading

vercel bot commented Sep 10, 2024 •

edited

Loading

jtran commented Sep 13, 2024 •

edited

Loading

Irev-Dev commented Sep 13, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading