Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move CZlib in linux #60

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

move CZlib in linux #60

wants to merge 6 commits into from

Conversation

makleso6
Copy link

I am using KituraNio on iOS, and it no need to use CZlib (zlib exists on Mac and iOS)

@makleso6
Copy link
Author

@djones6 Hi! Can you help me with CI? Why it is failed?

@makleso6
Copy link
Author

makleso6 commented Nov 18, 2019

I also install swift-development-snapshot on my local machine and it compile successfully
swift-DEVELOPMENT-SNAPSHOT-2019-09-26-a.xctoolchain

@makleso6 makleso6 mentioned this pull request Nov 18, 2019
@makleso6
Copy link
Author

It also fails on empty #61 PR

@djones6
Copy link
Contributor

djones6 commented Nov 19, 2019

@makleso6 it looks like the latest swift-nio doesn't compile on the older development snapshot this repo had configured for the CI. I'll update it to a recent 5.1 dev snapshot and restart the build.

@makleso6
Copy link
Author

@djones6 build passed, Thanks!

@djones6 djones6 requested a review from harish1992 November 20, 2019 09:39
Copy link
Contributor

@harish1992 harish1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@makleso6
Copy link
Author

makleso6 commented Dec 5, 2019

@djones6 CI fail again(

@harish1992
Copy link
Contributor

@djones6 CI fail again(

Hi @makleso6 , The build fails because of issue #63. PR #62 fixes the issue. Once merged you can rebase it to your change. Thanks.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants