[VIAME] Fix undefined or incorrect behavior in darknet_trainer #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per rule 20 of the "Sequenced-before rules" at https://en.cppreference.com/w/cpp/language/eval_order, starting in C++17 the right-hand side of an assignment is evaluated before the left-hand side, which is not the desired behavior. Prior to C++17, the behavior is, as I understand it, undefined.
predicative
changed the title
mattdawkins
force-pushed
the
viame/master
branch
from
662cc40
to
aa7b16d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per rule 20 of the "Sequenced-before rules" at https://en.cppreference.com/w/cpp/language/eval_order, starting in C++17 the right-hand side of an assignment is evaluated before the left-hand side, which is not the desired behavior.
Prior to C++17, the behavior is, as I understand it, undefined.