Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing ESGF example : Set time dimension to t instead of z #103

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fixing ESGF example : Set time dimension to t instead of z #103

merged 1 commit into from
Sep 17, 2024

Conversation

ayenpure
Copy link
Collaborator

This change sets the time dimension of the data to the T coordinate
instead of the Z coordinate while the example launches.

@ayenpure
Fixing ESGF example : Set time dimension to t instead of z
9b37d85 
  This change sets the time dimension of the data to the T coordinate
  instead of the Z coordinate while the example launches.
@ayenpure ayenpure requested a review from johnkit August 15, 2024 18:59
@johnkit johnkit added this to the Pan3D Sprint02 - Sep10 milestone Aug 27, 2024
johnkit
johnkit approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@johnkit johnkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is also a "z_scale" option under the "render" settings. We could probably delete that line too. Either way, yes, let's switch this from the half-baked cube display to 2D vs time.

@johnkit johnkit mentioned this pull request Sep 4, 2024
Closed
@johnkit johnkit merged commit 4fef3d7 into Kitware:main Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnkit johnkit johnkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pan3D Sprint02 - Sep10
Development

Successfully merging this pull request may close these issues.
2 participants
@ayenpure @johnkit