fix(ts): add default props to previous props

This avoids an infinite useEffect/setState loop via the modified flag.

Author: floryst

src/core-ts/DataArray.ts

@@ -1,16 +1,14 @@
 import vtkDataArray from '@kitware/vtk.js/Common/Core/DataArray';
-import { useEffect } from 'react';
-import { usePrevious } from '../utils-ts/usePrevious';
+import { vtkRange } from '@kitware/vtk.js/interfaces';
 import { TYPED_ARRAYS } from '@kitware/vtk.js/macros';
-import { useDataset, useFieldData } from './contexts';
-import { toTypedArray, TypedArrayLookup } from '../utils-ts';
+import { useEffect } from 'react';
 import { DataArrayValues } from '../types';
-import { vtkRange } from '@kitware/vtk.js/interfaces';
-import useUnmount from '../utils-ts/useUnmount';
-import { useOrderedUnmountEffect } from '../utils-ts/useOrderedUnmountEffect';
+import { toTypedArray, TypedArrayLookup } from '../utils-ts';
 import useGetterRef from '../utils-ts/useGetterRef';
-
-// -----
+import { useOrderedUnmountEffect } from '../utils-ts/useOrderedUnmountEffect';
+import { usePrevious } from '../utils-ts/usePrevious';
+import useUnmount from '../utils-ts/useUnmount';
+import { useDataset, useFieldData } from './contexts';
 
 interface Props {
   /**
@@ -52,7 +50,7 @@ const DefaultProps = {
 };
 
 export default function DataArray(props: Props) {
-  const prev = usePrevious(props);
+  const prev = usePrevious({ ...DefaultProps, ...props });
 
   const [daRef, getDataArray] = useGetterRef(() =>
     vtkDataArray.newInstance({

src/core-ts/PolyData.tsx

@@ -85,17 +85,22 @@ interface Props extends PropsWithChildren {
   connectivity?: string;
 }
 
+const DefaultProps = {
+  port: 0,
+  points: [],
+  connectivity: 'manual',
+};
+
 export default forwardRef(function PolyData(props: Props, fwdRef) {
   const {
-    port = 0,
-    points = [],
-    connectivity = 'manual',
+    port = DefaultProps.port,
+    points = DefaultProps.points,
+    connectivity = DefaultProps.connectivity,
     verts,
     lines,
     polys,
     strips,
   } = props;
-  const prev = usePrevious(props);
 
   const [pdRef, getPolyData] = useGetterRef(() => vtkPolyData.newInstance());
 
@@ -126,6 +131,8 @@ export default forwardRef(function PolyData(props: Props, fwdRef) {
 
   useImperativeHandle(fwdRef, () => dataset);
 
+  const prev = usePrevious({ ...DefaultProps, ...props });
+
   // update polydata
   useEffect(() => {
     const polyData = getPolyData();