3351 fix many actors performance hit #3366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finetjul
force-pushed
the
3351-fix-many-actors-performance-hit
branch
2 times, most recently
from
6c6b2da to
9004dee
Compare
Collaborator
|
@finetjul Does this improve the interaction with the scene when we have many actors ? ex in https://kitware.github.io/vtk-js/examples/IFCImporter/index.html?mergeGeometries=false |
Collaborator
|
Another thing that still bugs me is the memory usage in general and specifically GLTFImporter, i am not sure if it's the code i wrote or something in VTK.js that keeps arrays. DamangedHelmet is 7x the memory usage compared to Threejs for example |
daker
approved these changes
Nov 23, 2025
Collaborator
daker
left a comment
daker
left a comment
There was a problem hiding this comment.
LGTM, i did test it with IFC example it does improve the interaction with the scene.
Avoid using filter() and includes() that are slow operations. issue Kitware#3351
Provide the previously found view node to avoid a full search each time a prepass of buildPass is done issue Kitware#3351
enforceOrder was forcing the dataObjs nodes to be the first children. That had the disadvantage to make the OpenGLCamera the last item, and slow to be found. Instead, enforceOrder now simply enforce that the created missing nodes are following each others. fix #3497
finetjul
force-pushed
the
3351-fix-many-actors-performance-hit
branch
from
9004dee to
aef841e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Rendering is slow when a scene has many actors. This is slow since addMissingNodes() enforceOrder has been added.
Results
Performance should be back to before what they were before enforceOrder was added.
Changes
Add caching for OpenGLCamera node and do not enforce data objs to be at the beginning of the children list.
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting